Spotinst: Feature/add multi arch in VNG and resource tag specification#16099
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @yehielnetapp. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
area/provider/aws
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
Thanks @yehielnetapp. |
k8s-ci-robot
added
the
lgtm
| klog.V(4).Infof("Adding task: Ocean/%s", fi.ValueOf(ocean.Name)) | ||
| c.AddTask(ocean) | ||
|
|
||
| klog.V(4).Infof("Finish task: Ocean/%s", fi.ValueOf(ocean.Name)) |
There was a problem hiding this comment.
It doesn't matter, but (I think) AddTask should be almost instant (and only fails if there's a naming conflict, IIRC) - it just inserts an entry into a map.
| // convert spec from api that reply for multi arch data only in spec.images | ||
| if spec.Images != nil && len(spec.Images) > 1 { | ||
| spec.SetImageId(fi.PtrTo(fi.ValueOf(spec.Images[0].ImageId))) | ||
| actual.OtherArchitectureImages = append(actual.OtherArchitectureImages, fi.ValueOf(spec.Images[1].ImageId)) |
There was a problem hiding this comment.
Nit: Do you want to loop over these other images, so we support more than just 2 in future?
|
|
||
| return out | ||
| } | ||
| func buildImages(cloud awsup.AWSCloud, ImageID *string, OtherArchitectureImages []string) ([]*aws.Images, error) { |
There was a problem hiding this comment.
Nit: s/ImageID/imageID and s/OtherArchitectureImages/otherArchitectureImages
|
Thanks @yehielnetapp - a few nits, but nothing blocking /approve |
k8s-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Feature add
0) update spotinst SDK in vendor github.com/spotinst/spotinst-sdk-go@v1.171.0
1)It will be possible to set multi AMI per Virtual Node Group, one for each architecture (x86, arm)
2)add tag to track storage costs on their end on the VNG level.
this is logical PR of : #15839 after changes
in: #15839 (comment)