feat: Support multiple token verifiers in kops-controller#16140
Merged
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/nodeup
area/provider/aws
Member
Author
|
Breaking #16139 into more manageable chunks |
justinsb
force-pushed
the
multiple_verifiers
branch
from
7a70783 to
df9500e
Compare
This will allow us to support nodes running in multiple clouds. If we don't configure multiple verifiers, this should be a no-op.
justinsb
force-pushed
the
multiple_verifiers
branch
from
df9500e to
592b575
Compare
hakman
approved these changes
Nov 30, 2023
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rifelpet
reviewed
Nov 30, 2023
| } | ||
| klog.Infof("failed to verify token: %v", err) | ||
| } | ||
| return nil, fmt.Errorf("unable to verify token") |
Member
There was a problem hiding this comment.
I think this should wrap one of the non-nil errors that was received from the verifiers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to support nodes running in multiple clouds. If we
don't configure multiple verifiers, this should be a no-op.