Skip to content

aws: Add KMS to EBS CSI Driver and control plane#16173

Merged
k8s-ci-robot merged 3 commits into
kubernetes:masterfrom
hakman:relax_kms
Dec 13, 2023
Merged

aws: Add KMS to EBS CSI Driver and control plane#16173
k8s-ci-robot merged 3 commits into
kubernetes:masterfrom
hakman:relax_kms

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Dec 13, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2023
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Dec 13, 2023

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims December 13, 2023 01:15
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Dec 13, 2023

/cc @rifelpet

@hakuna-matatah
Copy link
Copy Markdown
Contributor

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@hakman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-amazonvpc ac7f184 link false /test pull-kops-e2e-cni-amazonvpc
pull-kops-e2e-cni-calico-ipv6 ac7f184 link false /test pull-kops-e2e-cni-calico-ipv6
pull-kops-e2e-cni-cilium-eni ac7f184 link false /test pull-kops-e2e-cni-cilium-eni

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims
Copy link
Copy Markdown
Member

dims commented Dec 13, 2023

/approve
/lgtm

not sure about the job failures, did not dig in...

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Dec 13, 2023

not sure about the job failures, did not dig in...

No worries, optional jobs and flakes.
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 28d59a6 into kubernetes:master Dec 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants