test: Set num-nodes flag#16176
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/cc @hakman |
|
/retest this is ready to be merged |
| ig = v | ||
| } | ||
| } | ||
| numNodes := int(*ig.Spec.MaxSize) // we assume that MinSize = Maxsize, this is true for e2e testing |
There was a problem hiding this comment.
This will be the size of the last nodes InstanceGroup. Should we instead sum the max size of all nodes InstanceGroups?
There was a problem hiding this comment.
No, the ginkgo wants the number of all nodes except the master/controplane IG. When we are using kops for e2e testing we assume there are exactly 2 IGs(one master and one worker). If we add the master ig to the count, you'll have an extra node that you can't schedule workloads onto without tweaking manifests to tolerate control plane taints
There was a problem hiding this comment.
Ah I was thinking in the case of there being multiple nodes IGs. This tester code can be used in cluster configurations that have multiple node IGs so I don't know if your assumption is always true.
upodroid
force-pushed
the
ginkgo-flags
branch
from
43198d8 to
7bac253
Compare
|
|
||
| const ( | ||
| skipRegexBase = "\\[Slow\\]|\\[Serial\\]|\\[Disruptive\\]|\\[Flaky\\]|\\[Feature:.+\\]|nfs|NFS|Gluster" | ||
| skipRegexBase = "\\[Slow\\]|\\[Serial\\]|\\[Disruptive\\]|\\[Flaky\\]|\\[Feature:.+\\]|nfs|NFS|Gluster|NodeProblemDetector" |
There was a problem hiding this comment.
I tried to adjust the prow job generator and it caused a big mess. We run ubuntu by default so it would need to be running most of the time. It is easier to skip, will open a PR in k/k now to park this behind a Feature tag
|
/retest We merged a PR in k/k to stop running NPD tests, the skip is needed for release branches |
| distro := CalculateDistroFromIG(ig) | ||
| if distro != "" { | ||
| klog.Infof("Setting --node-os-distro=%s", distro) | ||
| t.TestArgs += " --node-os-distro=" + distro |
There was a problem hiding this comment.
Don't remember, did we say we will move this to the generator for now?
There was a problem hiding this comment.
This is ready to merged
upodroid
force-pushed
the
ginkgo-flags
branch
from
2f13013 to
b71f618
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
added
the
tide/merge-method-squash
upodroid
force-pushed
the
ginkgo-flags
branch
from
b71f618 to
aec87b6
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Co-authored-by: upodroid <upodroid@users.noreply.github.com>
4 participants
There is a bug in the test framework where the -num-nodes flag must be explicitly set to avoid tests being skipped. It should be autocalculated but it is not working as intended.
Also, node-os-distro should be set to skip various tests that are OS specific in the kubernetes e2e test suite.
@dims