Skip to content

test: Improve cluster deletion defaults#16236

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
hakman:fix-config-cluster-delete
Jan 8, 2024
Merged

test: Improve cluster deletion defaults#16236
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
hakman:fix-config-cluster-delete

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Jan 8, 2024

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2024
@ameukam
Copy link
Copy Markdown
Member

ameukam commented Jan 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@hakman hakman force-pushed the fix-config-cluster-delete branch from 9b819ea to 9bef6ef Compare January 8, 2024 20:10
@k8s-ci-robot k8s-ci-robot added area/documentation and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 8, 2024
@ameukam
Copy link
Copy Markdown
Member

ameukam commented Jan 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Jan 8, 2024

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 443dd4a into kubernetes:master Jan 8, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants