Skip to content

chore: Remove support for Kubernetes 1.28 in kOps 1.34#17598

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
hakman:remove-k8s-1-28
Aug 30, 2025
Merged

chore: Remove support for Kubernetes 1.28 in kOps 1.34#17598
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
hakman:remove-k8s-1-28

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Aug 30, 2025

hakman added 2 commits August 30, 2025 15:37
@hakman
chore: Remove support for Kubernetes 1.28
d3b5bfc 
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman
hack/update-expected.sh
092073e 
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/api area/nodeup area/provider/aws Issues or PRs related to aws provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 30, 2025
@ameukam
Copy link
Copy Markdown
Member

ameukam commented Aug 30, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 30, 2025

/retest

@hakman
Skip failing tests
04fd259 
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 30, 2025

/test pull-kops-e2e-azure-cni-cilium

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 30, 2025

/test pull-kops-e2e-cni-cilium-etcd

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 30, 2025

Only flakes or known failures.
/approve
/override pull-kops-e2e-cni-amazonvpc
/override pull-kops-kubernetes-e2e-ubuntu-gce-build
/override pull-kops-e2e-cni-kuberouter
/override pull-kops-e2e-cni-cilium-etcd

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 30, 2025

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-amazonvpc, pull-kops-e2e-cni-cilium-etcd, pull-kops-e2e-cni-kuberouter, pull-kops-kubernetes-e2e-ubuntu-gce-build

Details

In response to this:

Only flakes or known failures.
/approve
/override pull-kops-e2e-cni-amazonvpc
/override pull-kops-kubernetes-e2e-ubuntu-gce-build
/override pull-kops-e2e-cni-kuberouter
/override pull-kops-e2e-cni-cilium-etcd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2025
@ameukam
Copy link
Copy Markdown
Member

ameukam commented Aug 30, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4d97716 into kubernetes:master Aug 30, 2025
39 checks passed
rifelpet
rifelpet reviewed Aug 30, 2025
View reviewed changes
upup/pkg/fi/cloudup/new_cluster.go
Comment on lines -940 to -944
if cluster.IsKubernetesLT("1.27") && cloudProvider == api.CloudProviderAWS {
g.Spec.InstanceMetadata = &api.InstanceMetadataOptions{
HTTPTokens: fi.PtrTo("required"),
}
}
Copy link
Copy Markdown
Member

@rifelpet rifelpet Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this should have been IsKubernetesGTE ? in which case we'd want to unconditionally set it. or rather, reintroduce it for k8s 1.34 and later unconditionally set it once we remove support for k8s 1.34. Same with the other InstanceMetadata assignments below.

Copy link
Copy Markdown
Member Author

@hakman hakman Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rifelpet it is already the default, putting it in the spec makes it very hard to change it if needed for addons:

kops/pkg/model/awsmodel/autoscalinggroup.go

Lines 192 to 193 in 4d97716

HTTPPutResponseHopLimit: fi.PtrTo(int32(1)),
HTTPTokens: fi.PtrTo(ec2types.LaunchTemplateHttpTokensStateRequired),

@hakman hakman deleted the remove-k8s-1-28 branch August 31, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rifelpet rifelpet rifelpet left review comments

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@ameukam ameukam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/nodeup area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hakman @ameukam @k8s-ci-robot @rifelpet