Skip to content

chore: bump kOps version in tests#17659

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
justinsb:bump_version_in_tests
Oct 11, 2025
Merged

chore: bump kOps version in tests#17659
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
justinsb:bump_version_in_tests

Conversation

@justinsb
Copy link
Copy Markdown
Member

@justinsb justinsb commented Oct 11, 2025

By doing this, we can set up to use the "right" version in more places (not pin to KOPS_RELEASE_VERSION). At least this is what I think we should be doing :-)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2025
@k8s-ci-robot k8s-ci-robot requested a review from hakman October 11, 2025 13:04
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Oct 11, 2025
@justinsb justinsb changed the title chore: bump kOps version in tests WIP: chore: bump kOps version in tests Oct 11, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 11, 2025
@justinsb
Copy link
Copy Markdown
Member Author

WIP because we'll at least have to update a lot of golden output

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2025
@hakman
Copy link
Copy Markdown
Member

hakman commented Oct 11, 2025

/lgtm
/approve
/override pull-kops-e2e-k8s-aws-calico

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-calico

Details

In response to this:

/lgtm
/approve
/override pull-kops-e2e-k8s-aws-calico

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2025
@hakman
Copy link
Copy Markdown
Member

hakman commented Oct 11, 2025

WIP because we'll at least have to update a lot of golden output

Approved, in case you decide to merge.

@justinsb justinsb changed the title WIP: chore: bump kOps version in tests chore: bump kOps version in tests Oct 11, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2025
@justinsb
Copy link
Copy Markdown
Member Author

Let's do it - I feel like we should do this anyway, and it's a pain to review so I don't want to put you through that again (thank you for reviewing!)

@k8s-ci-robot k8s-ci-robot merged commit f3a2985 into kubernetes:master Oct 11, 2025
27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants