Skip to content

aws: Tag Launch Template network interfaces#17773

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
hakman:aws-tag-instance-eni
Nov 26, 2025
Merged

aws: Tag Launch Template network interfaces#17773
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
hakman:aws-tag-instance-eni

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Nov 26, 2025

Closes: #3358

Ref: #3358 (comment)

image

Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 26, 2025
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Nov 26, 2025
@k8s-ci-robot k8s-ci-robot requested a review from zetaab November 26, 2025 03:31
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Nov 26, 2025

/cc @rifelpet @ameukam

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2025
@hakman hakman changed the title Aws tag instance eni aws: Tag Launch Template network interfaces Nov 26, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Nov 26, 2025

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2025
@ameukam
Copy link
Copy Markdown
Member

ameukam commented Nov 26, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit ae20734 into kubernetes:master Nov 26, 2025
27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Nov 26, 2025
k8s-ci-robot added a commit that referenced this pull request Nov 26, 2025
…-upstream-release-1.34

Automated cherry pick of #17773: aws: Tag Launch Template network interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kops doesn't tag a number of resources it creates

3 participants