Skip to content

Support API field mapping for bastion.loadBalancer.type#17858

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
rramkumar1:bastion-field-path
Jan 13, 2026
Merged

Support API field mapping for bastion.loadBalancer.type#17858
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
rramkumar1:bastion-field-path

Conversation

@rramkumar1
Copy link
Copy Markdown
Contributor

Note that this only fixes the exact bug in the linked issue. We ideally need to add all other fields in the bastion struct to this as well but it's not clear to me if the best way to do that is list all fields in the tree one by one or if there is a simpler way.

Ref: #17623

/assign @hakman

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @rramkumar1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2026
@hakman
Copy link
Copy Markdown
Member

hakman commented Jan 13, 2026

Note that this only fixes the exact bug in the linked issue. We ideally need to add all other fields in the bastion struct to this as well but it's not clear to me if the best way to do that is list all fields in the tree one by one or if there is a simpler way.

Agreed, there should be a more elegant solution.

@rramkumar1
Copy link
Copy Markdown
Contributor Author

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@rramkumar1: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Copy Markdown
Member

hakman commented Jan 13, 2026

/override pull-kops-e2e-k8s-aws-calico

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-calico

Details

In response to this:

/override pull-kops-e2e-k8s-aws-calico

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 370a257 into kubernetes:master Jan 13, 2026
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants