Support API field mapping for bastion.loadBalancer.type#17858
Support API field mapping for bastion.loadBalancer.type#17858k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
Hi @rramkumar1. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Agreed, there should be a more elegant solution. |
|
/retest |
|
@rramkumar1: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override pull-kops-e2e-k8s-aws-calico |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-calico DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Note that this only fixes the exact bug in the linked issue. We ideally need to add all other fields in the
bastionstruct to this as well but it's not clear to me if the best way to do that is list all fields in the tree one by one or if there is a simpler way.Ref: #17623
/assign @hakman