Feature: pull user defined images for warm pool instances#17861
Feature: pull user defined images for warm pool instances#17861k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
|
Hi @dezmodue. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2618704 to
ac5454b
Compare
|
/retest |
|
@dezmodue: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Verified that both containerRegistry and containerProxy settings work as expected with the additional images: With warmPool definition With container registry: Result of With container proxy: Result of Will change from |
ac5454b to
5aa6085
Compare
|
Pushed change to use Verified again: Result: |
|
/ok-to-test |
5aa6085 to
07f1a49
Compare
|
/retest |
|
/test pull-kops-e2e-k8s-gce-ipalias |
|
Hi, please let me know if there is anything I can do to help move this forward, thanks! |
07f1a49 to
f527430
Compare
f527430 to
2f0339d
Compare
|
Looks great. Thanks for adding this @dezmodue! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-upstream-release-1.34 Automated cherry pick of #17861: Feature: pull user defined images for warm pool instances
…-upstream-release-1.35 Automated cherry pick of #17861: Feature: pull user defined images for warm pool instances
|
@hakman thanks a lot for the help, any chance this could land also in 1.33? |
Sorry, but I don't think there's any plan for any 1.33 releases anymore. |
This PR adds the ability to define extra images that can be loaded on the nodes in the warm pool.
In some cases it can be convenient to download large container images during the warming phase to reduce the startup time of workloads after a node has been requested and joined the cluster. Extra images can be specified via the
pullExtraImagesfield and the timeout for the lifecycle hook can be tuned accordingly to allow for the operation to complete.Tested by building an initial cluster with an IG:
Validated that the nodes complete the kops-configuration without errors.
Then adding the warm pool in the IG spec:
Rolled the IG via kOps, then validated that the kops-configuration completed without errors in both the warm pool and non warm pool instances. The image specified in the spec is pulled during the warming phase and the timeout is correctly set to 1200.
kops get assets includes the image specified in the warm pool spec.