Enable EtcdEventsHTTP in scalability tests#17892
Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom Jan 29, 2026
Merged
Enable EtcdEventsHTTP in scalability tests#17892k8s-ci-robot merged 3 commits intokubernetes:masterfrom
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
Member
Author
hakman
approved these changes
Jan 28, 2026
k8s-ci-robot
added
lgtm
Member
|
/test presubmit-kops-aws-small-scale-ipalias-using-cl2 |
Member
|
/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2 |
Member
Author
|
/hold for me to verify the artifacts from presubmit-kops-aws-small-scale-amazonvpc-using-cl2 to make sure they look ok :) appreciate the quick review @hakman ! |
k8s-ci-robot
added
the
do-not-merge/hold
Member
Author
|
/test pull-kops-e2e-k8s-aws-calico |
dims
force-pushed
the
feature/etcd-events-http-featureflag-scalability
branch
from
56cfb03 to
4496194
Compare
k8s-ci-robot
removed
the
lgtm
Enable the EtcdEventsHTTP feature flag in scalability tests to use HTTP for the events etcd cluster, reducing TLS handshake overhead. This matches what GCE scale tests do and helps avoid connection proliferation issues at scale. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
This helps diagnose issues where feature flags may not be recognized, such as build caching problems or initialization ordering issues. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
feature/etcd-events-http-featureflag-scalability
branch
from
4496194 to
daa5988
Compare
Member
Author
|
/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2 |
The sflags library splits comma-separated values in --env flag arguments into separate slice elements. This breaks KOPS_FEATURE_FLAGS values like "EtcdEventsHTTP,AWSSingleNodesInstanceGroup" because they get split into separate entries in the Env slice. Fix by reassembling the original value: collect all entries starting from KOPS_FEATURE_FLAGS= until we hit another NAME=VALUE pattern, then join them back together with commas. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
k8s-ci-robot
added
size/M
Member
Author
|
/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2 |
Member
Author
|
/skip |
Member
Author
|
/test presubmit-kops-aws-small-scale-amazonvpc-using-cl2 |
rifelpet
approved these changes
Jan 28, 2026
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the EtcdEventsHTTP feature flag in scalability tests to use HTTP for the events etcd cluster, reducing TLS handshake overhead.
This matches what GCE scale tests do and helps avoid connection proliferation issues at scale.
Follow up to #17891