Skip to content

azure: Deploy cloud-controller-manager for node lifecycle and LB support#18197

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:azure-ccm
Apr 15, 2026
Merged

azure: Deploy cloud-controller-manager for node lifecycle and LB support#18197
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:azure-ccm

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Apr 14, 2026

/cc @rifelpet

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet April 14, 2026 16:13
@k8s-ci-robot k8s-ci-robot added area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/api area/nodeup size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 14, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 14, 2026

/test pull-kops-e2e-azure-cni-cilium

1 similar comment
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 14, 2026

/test pull-kops-e2e-azure-cni-cilium

rifelpet
rifelpet reviewed Apr 14, 2026
View reviewed changes
Comment thread .../models/cloudup/resources/addons/azure-cloud-controller.addons.k8s.io/k8s-1.31.yaml.template Outdated
Comment on lines +214 to +215
- --cluster-cidr=10.244.0.0/16
- --cluster-name=kubernetes
Copy link
Copy Markdown
Member

@rifelpet rifelpet Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two probably need to use template variables. maybe --allocate-node-cidrs and --configure-cloud-routes too.

Copy link
Copy Markdown
Member Author

@hakman hakman Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, just testing things for now.

Copy link
Copy Markdown
Member Author

@hakman hakman Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and ready for review.

@hakman hakman force-pushed the azure-ccm branch 2 times, most recently from 37cb88f to 6c1f805 Compare April 15, 2026 05:40
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 15, 2026

/test pull-kops-e2e-azure-cni-cilium

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 15, 2026

/test pull-kops-e2e-azure-cni-cilium

@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Apr 15, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 15, 2026

/test pull-kops-e2e-azure-cni-cilium

@hakman
azure: Deploy cloud-controller-manager for node lifecycle and LB support
1226217 
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 15, 2026

/test pull-kops-e2e-azure-cni-cilium

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 15, 2026

/retest-required

rifelpet
rifelpet reviewed Apr 15, 2026
View reviewed changes
Comment thread .../models/cloudup/resources/addons/azure-cloud-controller.addons.k8s.io/k8s-1.31.yaml.template
Comment on lines +218 to +219
- --leader-elect={{ .ExternalCloudControllerManager.LeaderElection.LeaderElect
}}
Copy link
Copy Markdown
Member

@rifelpet rifelpet Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- --leader-elect={{ .ExternalCloudControllerManager.LeaderElection.LeaderElect
}}
- --leader-elect={{ .ExternalCloudControllerManager.LeaderElection.LeaderElect }}

Copy link
Copy Markdown
Member Author

@hakman hakman Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kustomize artifact, but valid yaml

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 15, 2026 •
edited
Loading

@hakman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-aws-upgrade-k134-ko134-to-kstable-kolatest-many-addons 1226217 link false /test pull-kops-aws-upgrade-k134-ko134-to-kstable-kolatest-many-addons
pull-kops-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons 1226217 link false /test pull-kops-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons
pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons 1226217 link false /test pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman hakman requested a review from rifelpet April 15, 2026 13:52
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 15, 2026

/override pull-kops-e2e-azure-cni-cilium

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 15, 2026

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-azure-cni-cilium

Details

In response to this:

/override pull-kops-e2e-azure-cni-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 29e2e54 into kubernetes:master Apr 15, 2026
29 of 32 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rifelpet rifelpet rifelpet approved these changes

Assignees

@rifelpet rifelpet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/nodeup area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

3 participants

@hakman @k8s-ci-robot @rifelpet