Skip to content

psc/releng: Update references to the security release process#900

Merged
k8s-ci-robot merged 5 commits intokubernetes:masterfrom
justaugustus:security
Dec 9, 2019
Merged

psc/releng: Update references to the security release process#900
k8s-ci-robot merged 5 commits intokubernetes:masterfrom
justaugustus:security

Conversation

@justaugustus
Copy link
Copy Markdown
Member

@justaugustus justaugustus commented Dec 7, 2019 •
edited
Loading

  • psc/releng: Update references to the security release process

    • Include security-release-team@ as a contact in release-managers.md

      The Product Security Committee and Release Managers will now
      coordinate security releases using this list.

    • Ensure Branch Manager membership on release-managers-private is
      documented and included in the Release Manager onboarding template

    • Mention the Security Release Process in the Branch Manager handbook

    • Update table of contents in Patch Release Team handbook

  • lint: Fix markdown warnings in Release Team Lead handbook

  • release-team-lead: Remove reference to the private Release Managers list

    Security release coordination now happens between the Product Security
    Committee, Patch Release Team, Branch Managers, and SIG Chairs.

    Information regarding security releases will be disseminated to Release
    Team Leads by Branch Managers on a need-to-know basis.

  • release-team-lead: Add onboarding template

    Here we add an onboarding template for Release Team Leads and Lead
    Shadows and move information about requisite access from the handbook
    and into the issue template.

Signed-off-by: Stephen Augustus saugustus@vmware.com

/hold (there are few things I want to tweak on the RT Lead handbook before merge)
cc: @kubernetes/product-security-committee @kubernetes/release-engineering @kubernetes/release-team
ref: #896
/area release-eng release-team
/committee product-security
/milestone v1.17
/kind documentation cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 7, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Dec 7, 2019
@k8s-ci-robot k8s-ci-robot added area/release-team Issues or PRs related to the release-team subproject committee/security-response Denotes an issue or PR intended to be handled by the product security committee. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from jberkus and listx December 7, 2019 21:09
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 7, 2019
@justaugustus justaugustus mentioned this pull request Dec 7, 2019
Closed
3 tasks
saschagrunert
saschagrunert approved these changes Dec 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2019
@saschagrunert
Copy link
Copy Markdown
Member

saschagrunert commented Dec 7, 2019

/hold

For more eyes.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2019
@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Dec 8, 2019

Ready for review...
For Release Engineering subproject approval:
/assign @tpepper @calebamiles

For PSC approval:
/assign @tallclair @liggitt @cjcullen @lukehinds

For RT Leads visibility:
cc: @kubernetes/release-team-leads

@Bubblemelon Bubblemelon mentioned this pull request Dec 8, 2019
Closed
18 tasks
@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Dec 8, 2019

To look over RT Lead changes:
/assign @guineveresaenger @alejandrox1

@lukehinds lukehinds mentioned this pull request Dec 8, 2019
Open
liggitt
liggitt reviewed Dec 9, 2019
View reviewed changes
Comment thread release-engineering/role-handbooks/branch-manager.md Outdated

#### Security fixes

The Product Security Committee (PSC) may contact you if there are security fixes needed on the release branch.
Copy link
Copy Markdown
Member

@liggitt liggitt Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest adding the method of communication to expect?

Suggested change
The Product Security Committee (PSC) may contact you if there are security fixes needed on the release branch.
The Product Security Committee (PSC) may contact you via $mailing-list if there are security fixes needed on the release branch.

@justaugustus
psc/releng: Update references to the security release process
6386e33 
- Include security-release-team@ as a contact in release-managers.md

  The Product Security Committee and Release Managers will now
  coordinate security releases using this list.

- Ensure Branch Manager membership on release-managers-private is
  documented and included in the Release Manager onboarding template
- Mention the Security Release Process in the Branch Manager handbook
- Update table of contents in Patch Release Team handbook

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
lint: Fix markdown warnings in Release Team Lead handbook
aa964dc 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
release-team-lead: Remove reference to the private Release Managers list
7aaaf4f 
Security release coordination now happens between the Product Security
Committee, Patch Release Team, Branch Managers, and SIG Chairs.

Information regarding security releases will be disseminated to Release
Team Leads by Branch Managers on a need-to-know basis.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
release-team-lead: Add onboarding template
9f1a482 
Here we add an onboarding template for Release Team Leads and Lead
Shadows and move information about requisite access from the handbook
and into the issue template.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
release-team-lead: Alpha-sort reference links in handbook
4b7fe58 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Dec 9, 2019

PSC bits lgtm

saschagrunert
saschagrunert approved these changes Dec 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
:)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2019
cpanato
cpanato approved these changes Dec 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Copy Markdown
Member Author

justaugustus commented Dec 9, 2019

Releasing the hold as we have PSC and Releng approval.
If the RT Lead changes need to be addressed, let's do so in a follow-up.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 77b60f4 into kubernetes:master Dec 9, 2019
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

@jberkus jberkus Awaiting requested review from jberkus

@listx listx Awaiting requested review from listx

+1 more reviewer

@liggitt liggitt liggitt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@saschagrunert saschagrunert

@calebamiles calebamiles

@liggitt liggitt

@tpepper tpepper

@cpanato cpanato

@lukehinds lukehinds

@cjcullen cjcullen

@alejandrox1 alejandrox1

@guineveresaenger guineveresaenger

@tallclair tallclair

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/security-response Denotes an issue or PR intended to be handled by the product security committee. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.