Skip to content

Resolves: MTV-4863 | Enhance copy offload section with hints and recommendations#2322

Merged
avivtur merged 1 commit intokubev2v:mainfrom
avivtur:enhancment/storage-offload-improvments
Apr 16, 2026
Merged

Resolves: MTV-4863 | Enhance copy offload section with hints and recommendations#2322
avivtur merged 1 commit intokubev2v:mainfrom
avivtur:enhancment/storage-offload-improvments

Conversation

@avivtur
Copy link
Copy Markdown
Member

@avivtur avivtur commented Mar 26, 2026

📝 Links

📝 Description

Enhances the storage offload configuration section with smart vendor matching, recommendations, and optimality hints.

  • Vendor lookup tables mapping SCSI Vendor IDs and CSI provisioner strings to StorageVendorProduct for all 9 supported vendors (Pure, NetApp, Dell, IBM, HPE, Hitachi, Infinidat), with 45 unit tests
  • Grouped dropdowns: Target Storage and Storage Product dropdowns split into "Recommended (same vendor)" and "Other options" based on the selected source datastore vendor
  • Optimality hints: green/warning helper text indicating whether the offload configuration is optimal (vendor match) or suboptimal (mismatch fallback)
  • Copy offload badge on StorageMap review table rows that have offload configured
  • Test configuration button (disabled shell) ready to wire up when the backend dry-run endpoint is available

🎥 Demo

Screen.Recording.2026-03-26.at.10.20.17.mov

📝 CC://

@rgolangh


Merge automation commands
Command Description
/lgtm or /approve Add the approved label — PR will auto-merge when all checks pass
/retest Re-trigger Konflux pipelines (handled by Pipelines as Code)
/retest-gh Re-run failed GitHub Actions jobs
/retest-gh-all Re-run all GitHub Actions workflows from scratch
/retest-all Re-run failed GitHub Actions jobs + Konflux pipelines
/hold Prevent auto-merge even if approved and checks pass
/unhold Remove the hold and allow auto-merge again

Submitting a GitHub review approval (Approve) also adds the approved label.

When checks fail on an approved PR, the bot automatically retries failed GitHub Actions up to 3 times.
Konflux pipeline failures require a manual /retest to re-trigger.

@avivtur avivtur force-pushed the enhancment/storage-offload-improvments branch from 951b80c to 2dfda1f Compare March 26, 2026 10:07
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 26, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 30.73394% with 151 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.41%. Comparing base (13484d0) to head (7dcfcb4).
⚠️ Report is 1035 commits behind head on main.

Files with missing lines Patch % Lines
src/storageMaps/components/TargetStorageField.tsx 0.00% 38 Missing ⚠️
...ts/OffloadStorageIndexedForm/OffloadStorageRow.tsx 0.00% 20 Missing ⚠️
...ageMaps/components/TargetStorageWithSuggestion.tsx 0.00% 17 Missing ⚠️
src/storageMaps/hooks/useDatastoreVendor.ts 0.00% 16 Missing ⚠️
.../OffloadStorageIndexedForm/StorageProductField.tsx 43.47% 12 Missing and 1 partial ⚠️
...adStorageIndexedForm/OffloadStorageIndexedForm.tsx 0.00% 12 Missing ⚠️
...ffloadStorageIndexedForm/OffloadOptimalityHint.tsx 0.00% 11 Missing ⚠️
...eps/storage-map/CreatePlanStorageMapFieldTable.tsx 0.00% 8 Missing ⚠️
...geMapEdit/components/PlanStorageMapFieldsTable.tsx 0.00% 7 Missing ⚠️
...eMaps/create/fields/CreateStorageMapFieldTable.tsx 0.00% 6 Missing ⚠️
... and 1 more
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2322       +/-   ##
===========================================
- Coverage   36.81%   16.41%   -20.41%     
===========================================
  Files         158     1198     +1040     
  Lines        2548    21863    +19315     
  Branches      599     4080     +3481     
===========================================
+ Hits          938     3588     +2650     
- Misses       1428    18264    +16836     
+ Partials      182       11      -171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivtur avivtur force-pushed the enhancment/storage-offload-improvments branch 5 times, most recently from bc31c80 to 952e9f3 Compare March 29, 2026 08:03
Copy link
Copy Markdown
Contributor

@jpuzz0 jpuzz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor comments

@avivtur avivtur changed the title Resolves: MTV-4863 | Enhance copy offload section with hints and recommendations WIP Resolves: MTV-4863 | Enhance copy offload section with hints and recommendations Apr 6, 2026
@avivtur avivtur changed the title WIP Resolves: MTV-4863 | Enhance copy offload section with hints and recommendations [WIP] Resolves: MTV-4863 | Enhance copy offload section with hints and recommendations Apr 6, 2026
@avivtur avivtur force-pushed the enhancment/storage-offload-improvments branch 2 times, most recently from 86eb5a7 to c3742a8 Compare April 14, 2026 11:12
Comment thread src/storageMaps/utils/types.ts Outdated
Comment thread src/storageMaps/hooks/useDatastoreVendor.ts
@avivtur avivtur force-pushed the enhancment/storage-offload-improvments branch from c3742a8 to 0d01d8f Compare April 14, 2026 14:45
Copy link
Copy Markdown
Contributor

@jpuzz0 jpuzz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rgolangh
Copy link
Copy Markdown
Contributor

I like the way it conveys the message, optimal/ sub-optimal. Excellent work, thank you!

@avivtur avivtur force-pushed the enhancment/storage-offload-improvments branch 3 times, most recently from c4ce271 to 6f8c144 Compare April 15, 2026 16:29
@avivtur avivtur changed the title [WIP] Resolves: MTV-4863 | Enhance copy offload section with hints and recommendations Resolves: MTV-4863 | Enhance copy offload section with hints and recommendations Apr 15, 2026
…mmendations

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@avivtur avivtur force-pushed the enhancment/storage-offload-improvments branch from 6f8c144 to 7dcfcb4 Compare April 16, 2026 05:43
@sonarqubecloud
Copy link
Copy Markdown

@avivtur avivtur added this pull request to the merge queue Apr 16, 2026
Merged via the queue into kubev2v:main with commit bea9d19 Apr 16, 2026
15 checks passed
@avivtur avivtur deleted the enhancment/storage-offload-improvments branch April 16, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants