Merged
Conversation
Pedro-S-Abreu
changed the title
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2362 +/- ##
===========================================
- Coverage 36.81% 16.41% -20.41%
===========================================
Files 158 1198 +1040
Lines 2548 21863 +19315
Branches 599 4345 +3746
===========================================
+ Hits 938 3588 +2650
- Misses 1428 17572 +16144
- Partials 182 703 +521 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
avivtur
approved these changes
Apr 16, 2026
- Add data-testid to node selector delete button and update TargetNodeSelectorModal to use it, fixing wrong-row deletion - Fix ScriptEditModal locators: use correct test ID prefixes (field-row- and add-mapping-button) and fix removeScript targeting - Add data-testid="scripts-none" to ScriptsSection empty state and update AutomationTab assertion to match actual rendered text - Replace conditionally-rendered "Create migration plan" button assertion in i18n smoke test with always-visible "Migration plans" card title - Add missing hook_template.yaml test asset for plan-hooks tests Resolves: None Signed-off-by: Pedro Abreu <pabreu@redhat.com>
Use remove-row-{index} instead of fragile row.locator('button').last().
Resolves: None
Signed-off-by: Pedro Abreu <pabreu@redhat.com>
avivtur
force-pushed
the
fix/e2e-test-fixes
branch
from
f17c9b9 to
4eb5ff9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Links
None
📝 Description
Fix broken E2E test locators and assertions for node selector, customization scripts, i18n smoke, and plan hooks.
🎥 Demo
N/A — test-only changes.
📝 CC://