Description
Unit tests are needed for the new helper functions introduced in PR #4509 for separating virt-v2v conversion and inspection extra arguments.
Missing Test Coverage
The following functions in pkg/virt-v2v/conversion/conversion.go lack unit tests:
addConversionExtraArgs
addInspectorExtraArgs
addVirtV2vVsphereArgsForInspection
Context
These functions were introduced to separate extra arguments for conversion (VIRT_V2V_EXTRA_ARGS) from inspection (VIRT_V2V_INSPECTOR_EXTRA_ARGS), ensuring that conversion-specific args (e.g., --parallel) are not incorrectly passed to the inspector.
Unit tests should verify:
- Extra args are correctly applied when non-nil
- No args are added when nil
- The separation between conversion and inspection paths is maintained
References
Description
Unit tests are needed for the new helper functions introduced in PR #4509 for separating virt-v2v conversion and inspection extra arguments.
Missing Test Coverage
The following functions in
pkg/virt-v2v/conversion/conversion.golack unit tests:addConversionExtraArgsaddInspectorExtraArgsaddVirtV2vVsphereArgsForInspectionContext
These functions were introduced to separate extra arguments for conversion (
VIRT_V2V_EXTRA_ARGS) from inspection (VIRT_V2V_INSPECTOR_EXTRA_ARGS), ensuring that conversion-specific args (e.g.,--parallel) are not incorrectly passed to the inspector.Unit tests should verify:
References