Skip to content

feat: adds action to open app store page#50

Merged
kodiakhq[bot] merged 1 commit intomainfrom
issue-44
Jul 29, 2024
Merged

feat: adds action to open app store page#50
kodiakhq[bot] merged 1 commit intomainfrom
issue-44

Conversation

@philprime
Copy link
Copy Markdown
Member

No description provided.

@philprime philprime self-assigned this Jul 29, 2024
@philprime philprime changed the title feat: adds action to open app in app store feat: adds action to open app store page Jul 29, 2024
@github-actions
Copy link
Copy Markdown

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.

SwiftLint found issues

Severity File Reason
Warning ApiMessageResponseDto.swift:5 Types should be nested at most 1 level deep (nesting)
Warning ApiMessageResponseDto.swift:5 Types should be nested at most 1 level deep (nesting)
Warning ApiMessageResponseDto.swift:5 Types should be nested at most 1 level deep (nesting)
Warning ApiMessageResponseDto.swift:5 Types should be nested at most 1 level deep (nesting)
Warning View+OnLaunch.swift:51 Line should be 120 characters or less: currently 146 characters (line_length)
Warning OnLaunch.swift:86 Line should be 120 characters or less: currently 127 characters (line_length)
Warning OnLaunch.swift:88 Line should be 120 characters or less: currently 131 characters (line_length)
Warning OnLaunch.swift:126 Line should be 120 characters or less: currently 136 characters (line_length)
Warning OnLaunch.swift:178 Line should be 120 characters or less: currently 123 characters (line_length)
Warning OnLaunch.swift:197 Line should be 120 characters or less: currently 128 characters (line_length)
Warning OnLaunch.swift:206 Line should be 120 characters or less: currently 133 characters (line_length)
Warning OnLaunch.swift:293 Line should be 120 characters or less: currently 131 characters (line_length)
Warning OnLaunch.swift:303 Line should be 120 characters or less: currently 138 characters (line_length)

Generated by 🚫 Danger Swift against 8e91500

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 92 lines in your changes missing coverage. Please review.

Project coverage is 28.92%. Comparing base (2445d02) to head (8e91500).

Files Patch % Lines
...ces/OnLaunch/UI/Components/MessageActionView.swift 0.00% 43 Missing ⚠️
Sources/OnLaunch/OnLaunch.swift 0.00% 26 Missing ⚠️
Sources/OnLaunch/UI/MessageView.swift 0.00% 19 Missing ⚠️
Sources/OnLaunch/SwiftUI/View+OnLaunch.swift 0.00% 2 Missing ⚠️
Sources/OnLaunch/Utils/OnLaunchError.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   32.90%   28.92%   -3.99%     
==========================================
  Files           8        9       +1     
  Lines         392      446      +54     
==========================================
  Hits          129      129              
- Misses        263      317      +54     
Flag Coverage Δ
unittests 28.92% <0.00%> (-3.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 3bc83c6 into main Jul 29, 2024
@kodiakhq kodiakhq bot deleted the issue-44 branch July 29, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant