This repository was archived by the owner on Feb 27, 2026. It is now read-only.
fix: share auth for download url endpoint#254
Merged
danielalves96 merged 6 commits intokyantech:nextfrom Sep 10, 2025
Merged
Conversation
danielalves96
approved these changes
Sep 10, 2025
anthony0030
pushed a commit
to anthony0030/Palmr
that referenced
this pull request
Jan 13, 2026
Co-authored-by: Daniel Luiz Alves <daniel.xcoders@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Please make sure you are opening this Pull Request against the
nextbranch!📝 Description
It seems during my implementation of folders I had added
preValidationto the file download endpoint - which did not exist before. This is causing401errors sometimes when attempting to download files from public shares.This PR adds proper authentication to the download endpoint with support for public shares, protected shares, and private files with user authentication.
File in public share? → Yes → ✅ Allow
File in password-protected share + correct password? → Yes → ✅ Allow
Authenticated user owns file? → Yes → ✅ Allow
No valid access → ❌ Deny
🤖 Use of Artificial Intelligence (AI)
The use of AI tools is absolutely welcome and not an issue. For transparency and continuous improvement, please answer the following:
🧪 How Has This Been Tested?
Tested downloading files and folders from various pages in the dev environment and production build on my local machine.
🔄 Types of Changes
Check the relevant option(s) below:
✅ Checklist
nextbranch🙏 Thank you for your contribution!