This repository was archived by the owner on Feb 27, 2026. It is now read-only.
feat: add fallback mechanism when fs.rename is unsupported#272
Merged
danielalves96 merged 1 commit intokyantech:nextfrom Oct 2, 2025
Merged
feat: add fallback mechanism when fs.rename is unsupported#272danielalves96 merged 1 commit intokyantech:nextfrom
danielalves96 merged 1 commit intokyantech:nextfrom
Conversation
danielalves96
approved these changes
Oct 2, 2025
danielalves96
approved these changes
Oct 2, 2025
anthony0030
pushed a commit
to anthony0030/Palmr
that referenced
this pull request
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
FUSE filesystems don't seem to play nice with the
fs.rename(..)calls. When I try to upload any file, even if I put both thetemp-uploadsanduploadsdirs to live inside the same FUSE fs, this was the result:So, I've added a wrapper that reverts back to
fs.copy(..)+fs.unlink(..)when such an error is detected.🔗 Related Issue(s)
Haven't opened one, but can open if you need to log it.
💡 Motivation and Context
I don't have plenty of storage on my device, but I do have plenty in the cloud. Thus, taking inspiration from network drives, I mounted a Google Drive folder to use as my storage medium for Palmr, which is what I was using to reproduce the issue. I believe that this is a clean way to implement storage.
🤖 Use of Artificial Intelligence (AI)
The use of AI tools is absolutely welcome and not an issue. For transparency and continuous improvement, please answer the following:
🧪 How Has This Been Tested?
I've built the application through Docker with these changes applied and verified that even on the network drive, I was able to use Palmr properly.
📸 Screenshots (if appropriate)
Add any relevant screenshots to help explain your changes.
🔄 Types of Changes
Check the relevant option(s) below:
✅ Checklist
nextbranch🙏 Thank you for your contribution!