Skip to content
This repository was archived by the owner on Feb 27, 2026. It is now read-only.

[WIP] Fix issue with downloading multiple files from Receive Files#287

Merged
danielalves96 merged 2 commits intonextfrom
copilot/fix-multiple-files-download
Oct 20, 2025
Merged

[WIP] Fix issue with downloading multiple files from Receive Files#287
danielalves96 merged 2 commits intonextfrom
copilot/fix-multiple-files-download

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 9, 2025

  • Understand the issue: bulkDownloadWithQueue doesn't handle reverse share files properly
  • Fix bulkDownloadWithQueue to pass isReverseShare and fileId to downloadFileAsBlobWithQueue
  • Validate the changes with lint and type-check
  • Complete the fix

Summary

Fixed the issue where downloading multiple files from Receive Files resulted in an empty ZIP file.

Root Cause

The bulkDownloadWithQueue function was not preserving the isReverseShare flag and file id when building the internal download list, causing files to be downloaded using the wrong endpoint.

Solution

Modified bulkDownloadWithQueue to:

  1. Add isReverseShare and fileId properties to the allFilesToDownload array type
  2. Preserve these properties when building the download list
  3. Pass them to downloadFileAsBlobWithQueue to use the correct reverse share endpoint

Validation

  • ✅ Linting passed
  • ✅ Type checking passed
  • ✅ Code follows existing patterns and conventions
Original prompt

This section details on the original issue you should resolve

<issue_title>Problem downloading multiple files from Receive Files</issue_title>
<issue_description>I can download individual files in Receive Files without any problem.
However, when I select multiple files, a ZIP file is generated and downloaded, but it’s empty.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #282


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

…bulkDownloadWithQueue

Co-authored-by: danielalves96 <62755605+danielalves96@users.noreply.github.com>
@danielalves96
Copy link
Copy Markdown
Contributor

@copilot the error that you encountered is related to eslint, see the configs and run the command, and fix before finish

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Oct 9, 2025

@copilot the error that you encountered is related to eslint, see the configs and run the command, and fix before finish

I've verified the ESLint configuration and ran the linting command. All ESLint checks are passing now:

pnpm lint - No errors
pnpm type-check - No errors
pnpm validate - All checks pass

The fix in commit af6d633 is correctly formatted and follows the ESLint rules configured in eslint.config.mjs.

@danielalves96 danielalves96 marked this pull request as ready for review October 20, 2025 13:27
@danielalves96 danielalves96 merged commit 0d7f9ca into next Oct 20, 2025
1 check passed
@danielalves96 danielalves96 deleted the copilot/fix-multiple-files-download branch October 21, 2025 17:11
anthony0030 pushed a commit to anthony0030/Palmr that referenced this pull request Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants