Fix issue allowing multiple files with the same name - auto-rename on upload and rename operations by Copilot · Pull Request #309 · kyantech/Palmr

Copilot · 2025-10-20T14:10:36Z

Summary

This PR implements automatic renaming of files and folders when a duplicate name is detected, similar to Windows behavior. When a duplicate is detected, the system automatically appends a numeric suffix with a space (e.g., file (1).txt, folder (2)) to ensure unique names.

Changes Made

Implementation Details

New Files

apps/server/src/utils/file-name-generator.ts: Contains utilities for auto-renaming
- generateUniqueFileName(): For file uploads
- generateUniqueFileNameForRename(): For file rename operations
- generateUniqueFolderName(): For folder creation and rename operations
- parseFileName(): Parse filename into base and extension

Modified Files

apps/server/src/modules/file/controller.ts:
- Updated registerFile() to auto-rename on upload
- Updated checkFile() to return suggested name
- Updated updateFile() to auto-rename on rename
apps/server/src/modules/folder/controller.ts:
- Updated registerFolder() to auto-rename on creation
- Updated updateFolder() to auto-rename on rename (instead of returning error)
apps/server/.gitignore: Added build artifacts exclusion
apps/web/src/app/(shares)/r/[alias]/layout.tsx: Fixed Next.js 15 async headers() usage
apps/web/src/app/(shares)/s/[alias]/layout.tsx: Fixed Next.js 15 async headers() usage

Testing Results

All tests passed:

✅ Parse filename with single extension
✅ Parse filename with multiple dots
✅ No duplicate returns original name
✅ First duplicate gets (1) suffix with space
✅ Second duplicate gets (2) suffix with space
✅ Same name in different folder is allowed
✅ Rename file - no conflict
✅ Rename file - conflict exists
✅ Rename folder - no conflict
✅ Rename folder - conflict exists
✅ Create folder with conflict

Validation Results

✅ Server app: ESLint passes
✅ Web app: ESLint and TypeScript passes
✅ Docs app: ESLint and TypeScript passes

Behavior

File Operations:

Upload: Files with duplicate names in the same folder are automatically renamed: filename (N).extension
Rename: When renaming a file, if the new name conflicts with an existing file in the same folder, it's automatically renamed with a suffix

Folder Operations:

Create: When creating a folder, if the name conflicts with an existing folder in the same location, it's automatically renamed: foldername (N)
Rename: When renaming a folder, if the new name conflicts with an existing folder in the same location, it's automatically renamed with a suffix

General:

Files/folders with the same name in different folders are allowed (no conflict)
The checkFile API returns suggestedName if the filename will be renamed
Renaming logic respects folder boundaries
Behavior matches Windows OS file/folder naming conventions
Suffix format includes space before number for better readability (e.g., navarro (1) instead of navarro(1))

Security Summary

✅ CodeQL security scan completed with 0 alerts

No SQL injection risks (using Prisma ORM)
User isolation maintained
Folder access controls respected
No path traversal vulnerabilities

Fixes #266

Original prompt

This section details on the original issue you should resolve

<issue_title>multiple file with same name is allowed exist in the same directory</issue_title>
<issue_description>which can be confusing, better to auto rename it with extra suffix</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #266

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: danielalves96 <62755605+danielalves96@users.noreply.github.com>

danielalves96 · 2025-10-20T14:35:25Z

@copilot this error is related with linter. fix please.

Co-authored-by: danielalves96 <62755605+danielalves96@users.noreply.github.com>

Copilot · 2025-10-20T14:43:31Z

@copilot this error is related with linter. fix please.

Fixed TypeScript errors in Next.js 15 layout files by making getBaseUrl() async and awaiting the headers() call. All validation checks now pass. Commit: 72a3fab

danielalves96 · 2025-10-20T14:47:22Z

@copilot the auto renaming is working perfectly on uploads, but for renaming doesn`t works. i need this for renaming files or folders too. like windows os

Co-authored-by: danielalves96 <62755605+danielalves96@users.noreply.github.com>

Copilot · 2025-10-20T14:57:01Z

@copilot the auto renaming is working perfectly on uploads, but for renaming doesn`t works. i need this for renaming files or folders too. like windows os

Implemented auto-renaming for both file and folder rename operations. Now when you rename a file or folder to a name that already exists in the same location, it will automatically append a numeric suffix like (1), (2), etc., just like Windows does. This works for:

File renames (updateFile)
Folder renames (updateFolder)
Folder creation (registerFolder)

All tests passed. Commit: 6872c95

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

checkpoint.prisma.io
- Triggering command: /usr/local/bin/node /home/REDACTED/work/Palmr/Palmr/apps/server/node_modules/.pnpm/prisma@6.11.1_typescript@5.8.3/node_modules/prisma/build/child {"product":"prisma","version":"6.11.1","cli_install_type":"local","information":"","local_timestamp":"2025-10-20T14:54:42Z","project_hash":"91d7cb56","cli_path":"/home/REDACTED/work/Palmr/Palmr/apps/server/node_modules/prisma/build/index.js","cli_path_hash":"41b5463a","endpoint":"REDACTED","disable":false,"arch":"x64","os":"linux","node_version":"v20.19.5","ci":true,"ci_name":"GitHub Actions","command":"generate","schema_providers":["sqlite"],"schema_preview_features":[],"schema_generators_providers":["prisma-client-js"],"cache_file":"/home/REDACTED/.cache/checkpoint-nodejs/prisma-41b5463a","cache_duration":43200000,"remind_duration":172800000,"force":false,"timeout":5000,"unref":true,"child_path":"/home/REDACTED/work/Palmr/Palmr/apps/server/node_modules/.pnpm/prisma@6.11.1_typescript@5.8.3/node_modules/prisma/build/child","client_event_id":"","previous_client_event_id":"","check_if_update_available":true} (dns block)
- Triggering command: /usr/local/bin/node /home/REDACTED/work/Palmr/Palmr/apps/server/node_modules/.pnpm/prisma@6.11.1_typescript@5.8.3/node_modules/prisma/build/child {"product":"prisma","version":"6.11.1","cli_install_type":"local","information":"","local_timestamp":"2025-10-20T14:55:55Z","project_hash":"91d7cb56","cli_path":"/home/REDACTED/work/Palmr/Palmr/apps/server/node_modules/prisma/build/index.js","cli_path_hash":"41b5463a","endpoint":"REDACTED","disable":false,"arch":"x64","os":"linux","node_version":"v20.19.5","ci":true,"ci_name":"GitHub Actions","command":"db push --accept-data-loss","schema_providers":["sqlite"],"schema_preview_features":[],"schema_generators_providers":["prisma-client-js"],"cache_file":"/home/REDACTED/.cache/checkpoint-nodejs/prisma-41b5463a","cache_duration":43200000,"remind_duration":172800000,"force":false,"timeout":5000,"unref":true,"child_path":"/home/REDACTED/work/Palmr/Palmr/apps/server/node_modules/.pnpm/prisma@6.11.1_typescript@5.8.3/node_modules/prisma/build/child","client_event_id":"","previous_client_event_id":"","check_if_update_available":true} (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

danielalves96 · 2025-10-20T15:08:25Z

@copilot would be nice add an space before the version of renaming example:
actual: navarro(1)
nice: navarro (1)

and when i renaming, the file doest loaded (for downloads and poreviews)
error in renamed file:
GET http://localhost:3000/api/filesystem/download/40b04ee188cf46012d78c97d187ad63f70c11a464fc531403cf421623f259bcf 500 (Internal Server Error)

Co-authored-by: danielalves96 <62755605+danielalves96@users.noreply.github.com>

Copilot · 2025-10-20T15:14:15Z

@copilot would be nice add an space before the version of renaming example:
actual: navarro(1)
nice: navarro (1)
...

Updated the suffix format to include a space before the number. Now it generates names like navarro (1) instead of navarro(1), matching the style you requested. All tests pass with the new format. Commit: b1a7bcf

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

checkpoint.prisma.io

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

danielalves96 · 2025-10-20T15:16:30Z

@copilot and when i renaming, the file doest loaded (for downloads and poreviews)
error in renamed file:
GET http://localhost:3000/api/filesystem/download/40b04ee188cf46012d78c97d187ad63f70c11a464fc531403cf421623f259bcf 500 (Internal Server Error)

Copilot · 2025-10-20T15:20:54Z

@copilot and when i renaming, the file doest loaded (for downloads and poreviews)
error in renamed file:
GET http://localhost:3000/api/filesystem/download/40b04ee188cf46012d78c97d187ad63f70c11a464fc...

I need more information to diagnose the issue. Can you please check the server logs and share the full error message? The 500 error suggests something is failing on the server side.

Also, can you confirm:

Does the error happen immediately after renaming a file?
Does it happen for all renamed files or only specific ones?
Can you try renaming a file without creating a duplicate (so no suffix is added) and see if the download works?

The rename operation only changes the file name in the database, not the underlying file location (objectName), so downloads should continue to work. There might be an issue with how the renamed filename is being processed.

danielalves96 · 2025-10-20T16:52:55Z

@copilot
Requested file with password undefined
[DOWNLOAD] Error in 1760979150189-1c8p2enqe: Error: ENOENT: no such file or directory, stat '/Users/daniel/clones/Palmr/apps/server/uploads/cmddjchw80000gmiimqnxga2g/1758805195682-Rjn9at692HdR.png'
at async Object.stat (node:internal/fs/promises:1032:18)
at async FilesystemController.download (/Users/daniel/clones/Palmr/apps/server/src/modules/filesystem/controller.ts:206:21) {
errno: -2,
code: 'ENOENT',
syscall: 'stat',
path: '/Users/daniel/clones/Palmr/apps/server/uploads/cmddjchw80000gmiimqnxga2g/1758805195682-Rjn9at692HdR.png'
}

@copilot and when i renaming, the file doest loaded (for downloads and poreviews)
error in renamed file:
GET http://localhost:3000/api/filesystem/download/40b04ee188cf46012d78c97d187ad63f70c11a464fc...

I need more information to diagnose the issue. Can you please check the server logs and share the full error message? The 500 error suggests something is failing on the server side.

Also, can you confirm:

Does the error happen immediately after renaming a file?

Does it happen for all renamed files or only specific ones?

Can you try renaming a file without creating a duplicate (so no suffix is added) and see if the download works?

The rename operation only changes the file name in the database, not the underlying file location (objectName), so downloads should continue to work. There might be an issue with how the renamed filename is being processed.

Copilot · 2025-10-20T16:55:23Z

@copilot
Requested file with password undefined
[DOWNLOAD] Error in 1760979150189-1c8p2enqe: Error: ENOENT: no such file or directory, stat '/Users/daniel/clones/Palmr/apps/server/uploads/cmddjchw8...

The error shows the file doesn't exist at the expected path on disk. This is not related to the rename feature - the rename operation only changes the name field in the database, never the objectName (which is the actual file path).

The error ENOENT: no such file or directory means the physical file 1758805195682-Rjn9at692HdR.png is missing from the uploads folder, even though there's a database record for it. This can happen if:

The file upload didn't complete successfully
The file was manually deleted from the uploads folder
There's a database/filesystem sync issue

To verify the rename feature isn't the cause, check if:

Newly uploaded files work correctly
Renamed files that were working before rename still work
The issue only affects old files

The rename logic only updates the display name, not the storage location, so it shouldn't affect file downloads.

- Added a new script to clean up orphan file records in the database. - Introduced `fileExists` method in the StorageProvider interface and implemented it in S3StorageProvider. - Enhanced FilesystemController to check for file existence before download. - Minor formatting adjustments in the Prisma schema for consistency.

…n upload and rename operations (kyantech#309)

Initial plan

3706423

Copilot AI assigned Copilot and danielalves96 Oct 20, 2025

Copilot started work on behalf of danielalves96 October 20, 2025 14:11 View session

Copilot AI and others added 2 commits October 20, 2025 14:21

feat(server): add auto-rename for duplicate files in same directory

41100c7

Co-authored-by: danielalves96 <62755605+danielalves96@users.noreply.github.com>

test: verify duplicate file auto-rename functionality

72a3fab

Co-authored-by: danielalves96 <62755605+danielalves96@users.noreply.github.com>

Copilot AI requested a review from danielalves96 October 20, 2025 14:34

Copilot started work on behalf of danielalves96 October 20, 2025 14:35 View session

fix(web): await headers() in Next.js 15 layout files

6872c95

Co-authored-by: danielalves96 <62755605+danielalves96@users.noreply.github.com>

Copilot finished work on behalf of danielalves96 October 20, 2025 14:45

Copilot started work on behalf of danielalves96 October 20, 2025 14:47 View session

feat(server): add auto-rename for file and folder rename operations

b1a7bcf

Co-authored-by: danielalves96 <62755605+danielalves96@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix issue allowing multiple files with the same name~~ Fix issue allowing multiple files with the same name - auto-rename on upload and rename operations Oct 20, 2025

Copilot finished work on behalf of danielalves96 October 20, 2025 14:58

Copilot started work on behalf of danielalves96 October 20, 2025 15:09 View session

style: add space before suffix number in auto-rename format

366a5fe

Co-authored-by: danielalves96 <62755605+danielalves96@users.noreply.github.com>

Copilot finished work on behalf of danielalves96 October 20, 2025 15:15

Copilot started work on behalf of danielalves96 October 20, 2025 15:17 View session

Copilot finished work on behalf of danielalves96 October 20, 2025 15:22

Copilot started work on behalf of danielalves96 October 20, 2025 16:54 View session

Copilot finished work on behalf of danielalves96 October 20, 2025 16:56

danielalves96 marked this pull request as ready for review October 20, 2025 17:12

danielalves96 merged commit df31b32 into next Oct 20, 2025

danielalves96 deleted the copilot/auto-rename-duplicate-files branch October 21, 2025 17:11

anthony0030 pushed a commit to anthony0030/Palmr that referenced this pull request Jan 13, 2026

fix: issue allowing multiple files with the same name - auto-rename o…

4fa0e88

…n upload and rename operations (kyantech#309)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix issue allowing multiple files with the same name - auto-rename on upload and rename operations#309

Fix issue allowing multiple files with the same name - auto-rename on upload and rename operations#309
danielalves96 merged 7 commits intonextfrom
copilot/auto-rename-duplicate-files

Copilot AI commented Oct 20, 2025 •

edited

Loading

Uh oh!

danielalves96 commented Oct 20, 2025

Uh oh!

Copilot AI commented Oct 20, 2025

Uh oh!

danielalves96 commented Oct 20, 2025

Uh oh!

Copilot AI commented Oct 20, 2025 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

danielalves96 commented Oct 20, 2025 •

edited

Loading

Uh oh!

Copilot AI commented Oct 20, 2025 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

danielalves96 commented Oct 20, 2025

Uh oh!

Copilot AI commented Oct 20, 2025

Uh oh!

danielalves96 commented Oct 20, 2025

Uh oh!

Copilot AI commented Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Copilot AI commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Made

Implementation Details

New Files

Modified Files

Testing Results

Validation Results

Behavior

Security Summary

Comments on the Issue (you are @copilot in this section)

Uh oh!

danielalves96 commented Oct 20, 2025

Uh oh!

Copilot AI commented Oct 20, 2025

Uh oh!

danielalves96 commented Oct 20, 2025

Uh oh!

Copilot AI commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

danielalves96 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

danielalves96 commented Oct 20, 2025

Uh oh!

Copilot AI commented Oct 20, 2025

Uh oh!

danielalves96 commented Oct 20, 2025

Uh oh!

Copilot AI commented Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Oct 20, 2025 •

edited

Loading

Copilot AI commented Oct 20, 2025 •

edited

Loading

danielalves96 commented Oct 20, 2025 •

edited

Loading

Copilot AI commented Oct 20, 2025 •

edited

Loading