Skip to content

changed _findOptimShapeParam to a bisection algorithm#5

Merged
kylebeggs merged 2 commits intokylebeggs:masterfrom
yamanatoo:master
Aug 17, 2023
Merged

changed _findOptimShapeParam to a bisection algorithm#5
kylebeggs merged 2 commits intokylebeggs:masterfrom
yamanatoo:master

Conversation

@yamanatoo
Copy link
Contributor

To fix a case where the optimization loops until it reaches max_steps which can be expensive depending on the problem.
This happens when cond changes between 2 values, one higher than cond_range=[1] and the other lower than cond_range=[0]. It is dependent on the given delta c = 0.01 and the problem.

The bisection algorithm solves this and makes the optimization faster anyway.

@kylebeggs
Copy link
Owner

kylebeggs commented Aug 17, 2023

Thanks for the PR, this is a big improvement over the naive implementation here. We just need to bump the version number and then we can merge this.

@kylebeggs kylebeggs merged commit ec4fc59 into kylebeggs:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants