fix: UXC - proper product title & navigation on logo click#4490
fix: UXC - proper product title & navigation on logo click#4490mrCherry97 merged 6 commits intokyma-project:mainfrom
Conversation
chriskari
requested review from
a team,
KonradPietocha,
OliwiaGowor,
akucharska,
awoloszyn22,
dbadura and
mrCherry97
as code owners
mrCherry97
left a comment
mrCherry97
left a comment
There was a problem hiding this comment.
Visual spec is not fulfilled, Product Identifier should be blue, and also | divider and dashes are missing https://wiki.one.int.sap/wiki/spaces/visualcore/pages/2697898394/ShellBar+Horizon
The order should be SAP Logo – Product Identifier – divider line | – additional context (here: cluster switcher)
| navigateSafely(() => { | ||
| if (cluster?.name && window.location.pathname !== '/clusters') { | ||
| navigate(`/cluster/${encodeURIComponent(cluster.name)}/overview`); | ||
| } else { | ||
| navigate('/clusters'); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Also, idk if this if is useful, because we have only just 1 view which could navigate to the /clusters and it's a /clusters path, so basically it's making nothing.
There was a problem hiding this comment.
the problem is that when you navigate to the ClustersList, cluster?.name still holds the value of the previous cluster stored in state. Which means without this if statement the user would navigate back to the overview of the previous cluster upon clicking the logo, which is unintuitive and misleading
3 participants
Description
Changes proposed in this pull request:
Related issue(s)
#4309
Definition of done
backlog#4567