Skip to content

Fix bug dispatching messages to old sink#17888

Merged
kyma-bot merged 6 commits intokyma-project:mainfrom
marcobebway:17865-bug-fix-update-sub-sink
Aug 4, 2023
Merged

Fix bug dispatching messages to old sink#17888
kyma-bot merged 6 commits intokyma-project:mainfrom
marcobebway:17865-bug-fix-update-sub-sink

Conversation

@marcobebway
Copy link
Contributor

@marcobebway marcobebway commented Jul 25, 2023

Description

Fix bug dispatching messages to old sink.

Related issue(s)

@marcobebway marcobebway requested a review from a team as a code owner July 25, 2023 10:13
@marcobebway marcobebway requested a review from muralov July 25, 2023 10:13
@marcobebway marcobebway self-assigned this Jul 25, 2023
@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 9ce0d11
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64cbe2b229a1ae000837ad54
😎 Deploy Preview https://deploy-preview-17888--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcobebway marcobebway added kind/bug Categorizes issue or PR as related to a bug. area/eventing Issues or PRs related to eventing labels Jul 25, 2023
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2023
@marcobebway marcobebway linked an issue Jul 25, 2023 that may be closed by this pull request
Updating a subscription with an invalid sink dispatches messages to old sink #17865
Closed
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 25, 2023

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 25, 2023

/retest

3 similar comments
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 25, 2023

/retest

@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 25, 2023

/retest

@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 25, 2023

/retest

@marcobebway marcobebway force-pushed the 17865-bug-fix-update-sub-sink branch from 7550ae3 to 8e98ac9 Compare July 25, 2023 13:46
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 25, 2023

/retest

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2023
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 26, 2023

/retest

1 similar comment
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 26, 2023

/retest

@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 27, 2023

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2023
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 28, 2023

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 28, 2023

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 28, 2023

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 28, 2023

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 31, 2023 •
edited
Loading

Do we have integration/e2e tests for the scenario?

The tests components/eventing-controller/controllers/subscription/jetstream/reconciler_integration_test.go and components/eventing-controller/controllers/subscription/jetstream/reconciler_internal_unit_test.go should be enough for the time being.

@muralov
Copy link
Contributor

muralov commented Jul 31, 2023

do they test exactly the scenario where a JetStream subscription is deleted if the sink is invalid?

@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 31, 2023

do they test exactly the scenario where a JetStream subscription is deleted if the sink is invalid?

Yes, the test name: "Delete NATS subscriptions if Kyma subscription is updated with an invalid sink" does.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 31, 2023
@marcobebway
Copy link
Contributor Author

marcobebway commented Jul 31, 2023

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023
@marcobebway
Copy link
Contributor Author

marcobebway commented Aug 2, 2023

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2023
@marcobebway
Copy link
Contributor Author

marcobebway commented Aug 2, 2023

/hold
/retest

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2023
@marcobebway marcobebway force-pushed the 17865-bug-fix-update-sub-sink branch from 1a631db to c458ed3 Compare August 2, 2023 10:53
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 2, 2023
@marcobebway marcobebway requested a review from muralov August 2, 2023 10:53
@marcobebway
Copy link
Contributor Author

marcobebway commented Aug 2, 2023

/retest

1 similar comment
@marcobebway
Copy link
Contributor Author

marcobebway commented Aug 3, 2023

/retest

@marcobebway
Copy link
Contributor Author

marcobebway commented Aug 3, 2023

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@marcobebway marcobebway force-pushed the 17865-bug-fix-update-sub-sink branch from c458ed3 to 9ce0d11 Compare August 3, 2023 17:24
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 4, 2023
@kyma-bot kyma-bot merged commit 373e1b2 into kyma-project:main Aug 4, 2023
@marcobebway marcobebway deleted the 17865-bug-fix-update-sub-sink branch August 4, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muralov muralov muralov approved these changes

Assignees

@muralov muralov

@marcobebway marcobebway

Labels

area/eventing Issues or PRs related to eventing kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Updating a subscription with an invalid sink dispatches messages to old sink

3 participants

@marcobebway @muralov @kyma-bot