Skip to content

Remove deprecated components#18153

Merged
kyma-bot merged 3 commits intokyma-project:mainfrom
kolodziejczak:remove-deprecated-components
Sep 15, 2023
Merged

Remove deprecated components#18153
kyma-bot merged 3 commits intokyma-project:mainfrom
kolodziejczak:remove-deprecated-components

Conversation

@kolodziejczak
Copy link
Contributor

@kolodziejczak kolodziejczak commented Sep 12, 2023

Description

Changes proposed in this pull request:

  • Remove cluster-essentials and cluster-users components from installation
  • Remove related docs

Related issue(s)

#18143

@kolodziejczak kolodziejczak requested a review from a team September 12, 2023 11:43
@netlify
Copy link

netlify bot commented Sep 12, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a1d9632

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2023
@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit a1d9632
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6502c7f983d51b0008d96c2e
😎 Deploy Preview https://deploy-preview-18153--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2023
@kolodziejczak
Copy link
Contributor Author

/test all

@kolodziejczak
Copy link
Contributor Author

/retest

@kolodziejczak kolodziejczak marked this pull request as ready for review September 14, 2023 08:52
@kolodziejczak kolodziejczak requested review from a team as code owners September 14, 2023 08:52
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
@triffer triffer self-requested a review September 14, 2023 09:32
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 14, 2023
@barchw
Copy link
Contributor

barchw commented Sep 14, 2023

/hold
Why aren't we removing the resource directories?

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2023
@kolodziejczak
Copy link
Contributor Author

kolodziejczak commented Sep 14, 2023

/hold Why aren't we removing the resource directories?

@barchw not because of kyma cli?

@barchw
Copy link
Contributor

barchw commented Sep 14, 2023

/unhold
Leaving the directory for the purpose of backward compatibility

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2023
@kyma-bot kyma-bot merged commit 8560f88 into kyma-project:main Sep 15, 2023
@strekm strekm added area/security Issues or PRs related to security kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security Issues or PRs related to security kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants