Skip to content

Resolve resources in controller#18162

Merged
kyma-bot merged 13 commits intokyma-project:mainfrom
dbadura:move-resources
Sep 20, 2023
Merged

Resolve resources in controller#18162
kyma-bot merged 13 commits intokyma-project:mainfrom
dbadura:move-resources

Conversation

@dbadura
Copy link
Contributor

@dbadura dbadura commented Sep 13, 2023

Description

Changes proposed in this pull request:

  • add implementation to resolve resources in controller

Related issue(s)
kyma-project/serverless#248

@netlify
Copy link

netlify bot commented Sep 13, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d4d5b4d

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit d4d5b4d
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/650aa9aa54f94900087bdff0
😎 Deploy Preview https://deploy-preview-18162--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 13, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dbadura
Copy link
Contributor Author

dbadura commented Sep 13, 2023

/test all

@dbadura
Copy link
Contributor Author

dbadura commented Sep 14, 2023

/test all

}

func (fn *Function) Default(config *DefaultingConfig) {
fn.Spec.defaultFunctionResources(config, fn)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove it in next PR to not make this PR very big

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a draft: #18164

@dbadura
Copy link
Contributor Author

dbadura commented Sep 14, 2023

/test all

@dbadura
Copy link
Contributor Author

dbadura commented Sep 14, 2023

/test all

@dbadura dbadura marked this pull request as ready for review September 14, 2023 11:27
@dbadura dbadura requested a review from a team as a code owner September 14, 2023 11:27
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
@dbadura
Copy link
Contributor Author

dbadura commented Sep 14, 2023

/retest

@dbadura dbadura added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
Copy link
Contributor Author

@dbadura dbadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add runtime presets

@dbadura
Copy link
Contributor Author

dbadura commented Sep 18, 2023

/retest

@dbadura dbadura removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2023
@kyma-bot kyma-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2023
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 18, 2023
@pPrecel pPrecel self-assigned this Sep 18, 2023
@dbadura
Copy link
Contributor Author

dbadura commented Sep 19, 2023

/retest

@dbadura dbadura requested a review from a team as a code owner September 19, 2023 10:48
@dbadura
Copy link
Contributor Author

dbadura commented Sep 19, 2023

/retest

pPrecel
pPrecel previously approved these changes Sep 20, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 20, 2023
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 20, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 20, 2023
@kyma-bot kyma-bot merged commit cac8ab6 into kyma-project:main Sep 20, 2023
@dbadura dbadura deleted the move-resources branch September 20, 2023 08:41
@grego952 grego952 added the area/serverless Issues or PRs related to serverless label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/serverless Issues or PRs related to serverless lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants