Enhance git reference last commit checker#2170
Merged
ottersbot merged 3 commits intokyma-project:mainfrom Jan 13, 2026
Merged
Conversation
pPrecel
force-pushed
the
git-service
branch
3 times, most recently
from
24deda7 to
2a3a8cb
Compare
anoipm
reviewed
Jan 13, 2026
|
|
||
| //go:generate mockery --name=AsyncLatestCommitChecker --output=automock --outpkg=automock --case=underscore | ||
| type AsyncLatestCommitChecker interface { | ||
| MakeOrder(string, string, string, *GitAuth) |
Contributor
There was a problem hiding this comment.
The name MakeOrder is too ambiguous for me. Maybe something like SendRequest, CreateRequest, PlaceOrder?
| //go:generate mockery --name=AsyncLatestCommitChecker --output=automock --outpkg=automock --case=underscore | ||
| type AsyncLatestCommitChecker interface { | ||
| MakeOrder(string, string, string, *GitAuth) | ||
| CollectOrder(string) *OrderResult |
Contributor
There was a problem hiding this comment.
Mayge it could be something like GetResult, GetOrderResult?
implement migrate tests test new scenario remove old code fix imports test checker move checker declaration to main.go to pass main context to it implement simple cache with entry per function tests fix tests
anoipm
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
gitpackage to support ordering async checking instead of blocking reconciliation loop until operation is doneRelated issue(s)