File endings converted on Windows from CRLF to LF

[varunsh-xilinx]

With nbstripout, given a Jupyter notebook with CRLF endings on Windows:

nbstripout ./my_windows_file.ipynb

results in a zero return code but the working file has been updated on disk to have unix-style LF endings.

One fix I found was to remove the newline = '' setting here which seems to corrupt the output. Removing this results in the saved file continuing to have CRLF file endings and the return code is still 0. Removing the explicit newline arg allows Python to save the file with the OS native endings.

[kynan]

Thanks for reporting @varunsh-xilinx. Unfortunately I don't have access to a Windows system where I could reproduce this.

Apparently I added newline='' to address #190 in cb98ba9, however I no longer recall why this was necessary.

According to the docs, leaving newline as None should behave correctly.

Are tests passing on Windows when you remove newline='' ?

[varunsh-xilinx]

Yes, the tests pass for me locally removing that. The CI also run on Windows: wouldn't that confirm the tests pass?

[kynan]

OK, happy to change this then. Do you want to send a PR? Or would you prefer me to fix it?

[varunsh-xilinx]

Thank you for the quick response! Please go ahead with the fix