Skip to content

fix: support value update since SDK 29 despite persistent=false#430

Open
yhkee0404 wants to merge 17 commits intokyujin-cho:mainfrom
yhkee0404:pr-428
Open

fix: support value update since SDK 29 despite persistent=false#430
yhkee0404 wants to merge 17 commits intokyujin-cho:mainfrom
yhkee0404:pr-428

Conversation

@yhkee0404
Copy link
Copy Markdown
Contributor

@yhkee0404 yhkee0404 commented Dec 13, 2025

Screenshot_20251228-125252_Pixel IMS.jpg

Fixes #438 (comment), closes #398 (comment), resolves #403, by adding a new button to let users try ICarrierConfigLoader.overrideConfig or CarrierConfigManager.overrideConfig with persistent=false since the SecurityException which results frompersistent=true and makes the app crash is not thrown nor caught inside the app but from com.android.phone.

Support the different function signatures of ICarrierConfigLoader.overrideConfig and CarrierConfigManager.overrideConfig for SDK 29 in case of NoSuchMethodError.

Supports resetIms for SDK 29 where it was not added but following its implementation by disableIms and enableIms until SDK 33, catching NoSuchMethodError.

You can download and test the built apk here but need to uninstall the previous release if any: https://github.com/yhkee0404/pixel-volte-patch/releases/tag/1.3.1_PR_426_430_431_432_436

@yhkee0404 yhkee0404 marked this pull request as ready for review December 22, 2025 14:21
@kyujin-cho
Copy link
Copy Markdown
Owner

@yhkee0404 please resolve the merge conflict and get back to me

# Conflicts:
#	app/src/main/java/dev/bluehouse/enablevolte/Moder.kt
@yhkee0404
Copy link
Copy Markdown
Contributor Author

yhkee0404 commented Mar 7, 2026

@yhkee0404 please resolve the merge conflict and get back to me

Dear @kyujin-cho , sorry for this late response. To resolve the merge conflicts, I merged the latest v1.3.2 into this branch and refactored some lines from #426 just slightly, i.e. from getConfigForSubId into config, and added all of the following trivial updates: I made the unused phoneSubInfo nullable to prevent its absence from leading to a crash, reverted carrierName as non-nullable but adding the default value of an empty string to it, corrected both misspelled string literals in the SubscriptionModer.TAG and the log message for getIntArrayValue, and renamed the suggested overrideConfigPersistent and R.string.override_config_persistent into configPersistent and R.string.persist_config.

You can download and test the built apk from here but you need to uninstall the previous installation before installing this customized version: https://github.com/yhkee0404/pixel-volte-patch/releases/tag/1.3.2_PR_428_TEST . It works as I tested, and as previously tested by others: #438 (comment) , #449 (comment), #396 (comment), #453 (comment) ,

I have been working on both enhancing the core logic of turning the volte option including VOIMS_OPT_IN_STATUS, and ensuring that the shizuku permission is granted and the subscription is active before every user action. If you have any tip on VOIMS_OPT_IN_STATUS, please advise me.

It is such an honor that my #426 was accepted, and thank you for including it in v1.3.2! It must have helped a lot of users including this one: #445 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App crash on Android 16(BP4A.251205.006) [Bug] Crashes and functional failure App crashes on A16 QPR2 Beta 3

2 participants