fix: sync qs tile code between ims and volte

[yhkee0404]

pixel-volte-patch/app/src/main/java/dev/bluehouse/enablevolte/IMSStatusQSTileService.kt

Lines 34 to 37 in 240d0b2

	private val imsActivated: Boolean? get() {
	/*
	* true: VoLTE enabled
	* false: VoLTE disabled

pixel-volte-patch/app/src/main/java/dev/bluehouse/enablevolte/VoLTEConfigToggleQSTileService.kt

Lines 40 to 43 in 240d0b2

	private val volteEnabled: Boolean? get() {
	/*
	* true: VoLTE enabled
	* false: VoLTE disabled

You can download and test the built apk here but need to uninstall the previous release if any: https://github.com/yhkee0404/pixel-volte-patch/releases/tag/1.3.1_PR_426_430_431_432

[yhkee0404]

Isn't here a race condition when the second read value of volteEnabled may get different from the first one and become a non-repeatable read? On the contrary, the similar updates from volteEnabled inside toggleVoLTEStatus or those from imsActivated inside IMSStatusQSTileService.refreshStatus have no bugs like this one.

[yhkee0404]

It seems we should catch IllegalStateException thrown from Shizuku according to its README:

pixel-volte-patch/app/src/main/java/dev/bluehouse/enablevolte/IMSStatusQSTileService.kt

Lines 23 to 31 in 240d0b2

	try {
	if (checkShizukuPermission(0) == ShizukuStatus.GRANTED && carrierModer.deviceSupportsIMS) {
	val sub =
	carrierModer.getActiveSubscriptionInfoForSimSlotIndex(this.simSlotIndex)
	?: return null
	return SubscriptionModer(this.applicationContext, sub.subscriptionId)
	}
	} catch (_: IllegalStateException) {
	}

pixel-volte-patch/app/src/main/java/dev/bluehouse/enablevolte/VoLTEConfigToggleQSTileService.kt

Lines 28 to 37 in 421c10a

	try {
	if (checkShizukuPermission(0) == ShizukuStatus.GRANTED && carrierModer.deviceSupportsIMS) {
	carrierModer.subscriptions
	val sub =
	carrierModer.getActiveSubscriptionInfoForSimSlotIndex(this.simSlotIndex)
	?: return null
	return SubscriptionModer(this.applicationContext, sub.subscriptionId)
	}
	} catch (_: IllegalStateException) {
	}

But why do you catch IllegalStateException for moder.isIMSRegistered or moder.isVoLteConfigEnabled?:

pixel-volte-patch/app/src/main/java/dev/bluehouse/enablevolte/IMSStatusQSTileService.kt

Lines 41 to 44 in 240d0b2

	try {
	return moder.isIMSRegistered
	} catch (_: IllegalStateException) {
	}

pixel-volte-patch/app/src/main/java/dev/bluehouse/enablevolte/VoLTEConfigToggleQSTileService.kt

Lines 48 to 51 in 421c10a

	try {
	return moder.isVoLteConfigEnabled
	} catch (_: IllegalStateException) {
	}