remote/client: suppress gRPC error message on shutdown#1605
Merged
Bastian-Krause merged 1 commit intolabgrid-project:masterfrom Feb 12, 2025
Merged
Conversation
Emantor
previously approved these changes
Feb 12, 2025
This is a workround for the gRPC issue grpc/grpc#38679. Since Python 3.12, an empty exception message is printed from gRPC during shutdown, although nothing seems to go wrong. As this is confusing for users, suppress the message by closing stderr. When in debug mode, we keep it open. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
jluebbe
force-pushed
the
suppress-grpc-error-message
branch
from
31789ab to
2dc889c
Compare
Emantor
approved these changes
Feb 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #1605 +/- ##
======================================
Coverage 55.8% 55.8%
======================================
Files 170 170
Lines 13376 13378 +2
======================================
+ Hits 7468 7470 +2
Misses 5908 5908
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bastian-Krause
approved these changes
Feb 12, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workround for the gRPC issue grpc/grpc#38679.
On Python 3.12, an empty exception message is printed from gRPC during shutdown, although nothing seems to go wrong. As this is confusing for users, suppress the message by closing stderr. When in debug mode, we keep it open.