refactor(GCP): convert templates into TF Modules#50
Merged
Conversation
12d6c01 to
27ddb53
Compare
27ddb53 to
89b716b
Compare
As a Lacework user that uses Terraform to configure Lacework and Google Cloud resources, I would like to have reusable modules that I can plug-and-play into my internal Terraform plans, So I don't have to clone this repository and I can use all my best practices to use Terraform internally. JIRA: ALLY-148 Closes #49 Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
89b716b to
d7b83f7
Compare
scottford-lw
approved these changes
Jul 15, 2020
Contributor
scottford-lw
left a comment
There was a problem hiding this comment.
Great work @afiune ⭐ 👍
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
9e956d6 to
f6e393a
Compare
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
c796bf9 to
cf5d91c
Compare
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
26b3916 to
85de09e
Compare
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
2177b4f to
eadc074
Compare
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
ddc0f47 to
cc10dd0
Compare
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
9453b03 to
5db2372
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User Story
As a Lacework user that uses Terraform to configure Lacework and Google Cloud resources,
I would like to have reusable modules that I can plug-and-play into my internal Terraform plans,
So I don't have to clone this repository and I can use all my best practices to use Terraform internally.
Create a GCP Config Integration (Project Level)
Create a GCP Config Integration (Organization Level)
Create a GCP Audit Log Integration (Project Level)
Create a GCP Audit Log Integration (Organization Level)
JIRA: ALLY-148
Closes #49
Signed-off-by: Salim Afiune Maya afiune@lacework.net