feat(aws): parameterize time_sleep duration with input wait_time#62
Merged
afiune merged 3 commits intolacework:masterfrom Aug 25, 2020
dh11640:parameterize-time-sleep
Merged
feat(aws): parameterize time_sleep duration with input wait_time#62afiune merged 3 commits intolacework:masterfrom dh11640:parameterize-time-sleep
afiune merged 3 commits intolacework:masterfrom
dh11640:parameterize-time-sleep
Conversation
afiune
reviewed
Aug 25, 2020
Contributor
afiune
left a comment
There was a problem hiding this comment.
This change looks great, I have just two quick comments:
- Set the default time to
10s - Add a quick documentation about this new input in the Inputs sectio of the README.md
aws/modules/iam_role/variables.tf
Outdated
|
|
||
| variable "wait_time" { | ||
| type = string | ||
| default = "5s" |
Contributor
There was a problem hiding this comment.
Can we change the default to be 10s? I think we want to make increase the default so that others won't have to customize it that often.
Contributor
Author
There was a problem hiding this comment.
Oops, missed the readme bit. Just pushed that as well
Contributor
|
Just upgraded our demo environment and ran a After applied the time resources were destroyed and the new ones took their place: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Parameterize the create_duration parameter for time_sleep resources.
Closes #61