feat: implement ENRRequestMessage encoding#137
Merged
Conversation
azteca1998
added a commit
that referenced
this pull request
Feb 20, 2026
The assertoor upstream repo merged a major refactoring (PR #137) on Feb 19 that introduced breaking changes to the task lifecycle and transaction submission engine. Since our configs fetched playbooks from `refs/heads/master`, every CI run after the merge started failing the Blob & Stability Check. Pin all 4 playbook references to c35b5c3a5f (the last master commit before the breaking merge) so CI is stable while upstream settles.
azteca1998
added a commit
that referenced
this pull request
Feb 20, 2026
…ions The assertoor upstream repo merged a major refactoring (PR #137) on Feb 19 and released v0.0.18 on Feb 20, introducing breaking changes to the task lifecycle and transaction submission engine. Since our configs used `assertoor:latest` and fetched playbooks from `refs/heads/master`, every CI run after the release started failing the Blob & Stability Check (even geth-only nodes fail). Pin the assertoor Docker image to v0.0.17 (last stable pre-refactoring release) and all 4 playbook references to c35b5c3a5f (the last master commit before the breaking merge) so CI is stable while upstream settles.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
## Summary Pin all assertoor playbook URL references from `refs/heads/master` to a specific commit (`c35b5c3a5f`) — the last `master` commit before ethpandaops/assertoor PR #137 (major refactoring) was merged. ## Motivation Since Feb 19 ~17:26 UTC, the assertoor upstream merged a [major refactoring](ethpandaops/assertoor#137) that introduced breaking changes: - `stopChildOnResult` removed (tasks now self-complete) - `failTaskCount` / `succeedTaskCount` replaced with `failureThreshold` / `successThreshold` - Transaction submission engine replaced with spamoor Since our configs fetched playbooks from `refs/heads/master`, every CI run after the merge fails the **Blob & Stability Check** — including runs with zero code changes. ## Changes Pinned 4 playbook URLs across 3 files: - `network_params_blob.yaml` — `blob-transactions-test.yaml` - `network_params_tx.yaml` — `eoa-transactions-test.yaml` - `network_params_ethrex_multiple_cl.yaml` — `blob-transactions-test.yaml` + `eoa-transactions-test.yaml` ## Note Pinning the playbook URLs may not be sufficient on its own — if Kurtosis is also pulling the latest assertoor Docker image (with the new runtime), the old playbooks may still be interpreted differently. We may also need to pin the assertoor image version in the network params configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #132, #136
Motivation
Implement discv4 protocol
Description
Enables
ENRRequestMessageencodingCloses #88