Update ContentType.php#264
Open
tomolimo wants to merge 2 commits into
Open
Conversation
To be able to cope with mimetype like type/* Signed-off-by: tomolimo <olivier.moron@araymond.com>
Xerkus
reviewed
May 31, 2024
Delete the escape char that is not needed in front of * in [] Signed-off-by: tomolimo <olivier.moron@araymond.com>
Member
|
This change will need an accompanying unit test. Both in reading content type from string and returning expected string representation with |
Author
|
Unfortunately, I'will not have time to do it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to cope with mimetype like type/*
Description
fixes #119
eml file to test this bug is here: https://gist.github.com/rikvdh/489e13b22f9012db2dcd9f5046b53e43