feat: Support min_tokens and ignore_eos parameters#190
Merged
Jiayi Ni (jiayin-nvidia) merged 4 commits intolangchain-ai:mainfrom Sep 9, 2025
Merged
Conversation
Jiayi Ni (jiayin-nvidia)
force-pushed
the
support_min_tokens_and_ignore_eos
branch
from
f7d7f2c to
7bce19f
Compare
Jiayi Ni (jiayin-nvidia)
requested a review
from Soumili Nandi (soumilinandi)
| stop=None, | ||
| ) | ||
| assert payload["min_tokens"] == 10 | ||
| assert "ignore_eos" not in payload |
Collaborator
There was a problem hiding this comment.
do we need to check ignore_eos in this min_tokens test? seems independent?
Collaborator
Author
There was a problem hiding this comment.
Yes, this sounds good. Let me add a separate test case where the parameters are not set (default None values and not appear in the payload).
Collaborator
There was a problem hiding this comment.
yes that would be good to check for covering other none cases too
Collaborator
|
Jiayi Ni (@jiayin-nvidia) Do you think we can add integration tests for this parameter with a model that supports it? |
Jiayi Ni (jiayin-nvidia)
force-pushed
the
support_min_tokens_and_ignore_eos
branch
from
7464845 to
0acef44
Compare
Jiayi Ni (jiayin-nvidia)
requested a review
from Soumili Nandi (soumilinandi)
Soumili Nandi (soumilinandi)
approved these changes
Sep 8, 2025
Collaborator
Soumili Nandi (soumilinandi)
left a comment
Soumili Nandi (soumilinandi)
left a comment
There was a problem hiding this comment.
looks good! ✌️
Jiayi Ni (jiayin-nvidia)
force-pushed
the
support_min_tokens_and_ignore_eos
branch
from
94e211b to
21da604
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.