Skip to content

[5.7] Align Mailable dynamic parameter case to View (camel). #24232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 1 commit into from
May 17, 2018
Merged

[5.7] Align Mailable dynamic parameter case to View (camel). #24232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Mail/Mailable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,7 @@ public function withSwiftMessage($callback)
public function __call($method, $parameters)
{
if (Str::startsWith($method, 'with')) {
return $this->with(Str::snake(substr($method, 4)), $parameters[0]);
return $this->with(Str::camel(substr($method, 4)), $parameters[0]);
}

throw new BadMethodCallException(sprintf(
Expand Down
2 changes: 1 addition & 1 deletion tests/Mail/MailMailableTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public function testMailableBuildsViewData()

$expected = [
'first_name' => 'Taylor',
Copy link
Copy Markdown

@ghost ghost Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is lastName in CamelCase but first_name isn't?

'last_name' => 'Otwell',
'lastName' => 'Otwell',
'framework' => 'Laravel',
];

Expand Down