Draft
Conversation
timacdonald
force-pushed
the
mysql-9
branch
5 times, most recently
from
20408b5 to
a3d40ed
Compare
timacdonald
commented
Mar 19, 2026
| DB_PASSWORD: password | ||
| DB_COLLATION: utf8mb4_unicode_ci | ||
|
|
||
| mysql-9: |
Member
Author
There was a problem hiding this comment.
Test against mysql 9 specifically
timacdonald
commented
Mar 19, 2026
| use UnitEnum; | ||
|
|
||
| use function Illuminate\Support\enum_value; | ||
| use function Laravel\Pulse\Support\enum_value; |
Member
Author
There was a problem hiding this comment.
This was introduced in another PR but the tests were failing before we merged it. I've backported the functionality.
timacdonald
commented
Mar 19, 2026
| 'components' => [], | ||
| ]) | ||
| ->assertOk(); | ||
| expect(Route::getRoutes()->get('POST')[ltrim(livewireUpdateEndpoint(), '/')]->gatherMiddleware()) |
Member
Author
There was a problem hiding this comment.
Livewire has changed a lot of internals. I've made this test more of a unit test. Isn't 100, but should do the trick
timacdonald
commented
Mar 19, 2026
| ->throw() | ||
| ->output(); | ||
| [$firstEntryKey, $lastEntryKey] = collect(explode("\n", $output))->only([17, 21])->values(); | ||
| $lines = collect(explode("\n", $output)); |
Member
Author
There was a problem hiding this comment.
Redis has changed its output format.
timacdonald
commented
Mar 19, 2026
| Gate::define('viewPulse', fn ($user = null) => true); | ||
| Config::set('pulse.ingest.trim.lottery', [1, 1]); | ||
| Config::set([ | ||
| 'database.redis.options.prefix' => 'laravel_database_', |
Member
Author
There was a problem hiding this comment.
Laravel 13 has changed the default key. Setting it to stick to the original.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.