Conversation
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to f40e839 in 1 minute and 15 seconds
More details
- Looked at
58lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pkg/cap/cap.go:134
- Draft comment:
The comment abovematchStringListOrWildcardshould clarify that it checks for the presence of "*" or the specific item in the list. - Reason this comment was not posted:
Confidence changes required:10%
The functionmatchStringListOrWildcardis correctly implemented, but the comment above it is slightly misleading. It should mention that the function checks for the presence of "*" or the specific item in the list.
Workflow ID: wflow_UA7EP4zf8aQIF8cs
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Enhance
TailscaleAuthMiddlewareincap.goto support wildcard capability checks for methods and endpoints usingmatchStringListOrWildcard.TailscaleAuthMiddlewareincap.goto support wildcard "*" inMethodsandEndpointsfor capability checks.matchStringListOrWildcardfunction incap.goto handle wildcard logic.github.com/lbrlabs/tacl/pkg/capinmain.go.This description was created by
for f40e839. It will automatically update as commits are pushed.
Fixes #10