Skip to content

feat: add Terraform provider for TACL with resources and data sources#14

Merged
jaxxstorm merged 1 commit intomainfrom
terraform
Jan 21, 2025
Merged

feat: add Terraform provider for TACL with resources and data sources#14
jaxxstorm merged 1 commit intomainfrom
terraform

Conversation

@jaxxstorm
Copy link
Copy Markdown
Member

@jaxxstorm jaxxstorm commented Jan 21, 2025

Important

Adds a Terraform provider for TACL with resources and data sources for managing ACLs, auto-approvers, DERP maps, groups, hosts, and settings.

  • Provider:
    • Adds taclProvider in provider.go with OAuth-based authentication support.
    • Configures HTTP client and endpoint for TACL server.
  • Resources:
    • Implements tacl_acl, tacl_auto_approvers, tacl_derpmap, tacl_group, tacl_host, and tacl_settings resources with CRUD operations.
    • Uses HTTP requests to interact with TACL server for resource management.
  • Data Sources:
    • Implements tacl_acl, tacl_auto_approvers, tacl_derpmap, tacl_group, tacl_host, and tacl_settings data sources.
    • Retrieves data from TACL server using HTTP GET requests.
  • Examples:
    • Provides example Terraform configurations for each resource in terraform/examples/.
  • Dependencies:
    • Updates go.mod and go.sum with necessary dependencies for Terraform plugin framework and TACL client.

This description was created by Ellipsis for 9ab9e30. It will automatically update as commits are pushed.


Fixes #5

@ellipsis-dev ellipsis-dev bot changed the title ... feat: add Terraform provider for TACL with resources and data sources Jan 21, 2025
@jaxxstorm jaxxstorm merged commit 09288d0 into main Jan 21, 2025
@jaxxstorm jaxxstorm deleted the terraform branch January 21, 2025 19:57
Copy link
Copy Markdown

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 9ab9e30 in 1 minute and 14 seconds

More details
  • Looked at 3902 lines of code in 28 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. go.work:1
  • Draft comment:
go 1.23
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    Go version specifications in go.work files typically don't require patch versions. However, including the patch version is not incorrect and doesn't cause any issues. This seems like a style preference rather than a necessary change. There's no strong evidence that removing the patch version is required or beneficial.
    The patch version might be intentionally specified for reproducibility reasons. Also, this is a minor style issue that doesn't affect functionality.
    Since this is purely a style preference without clear benefits, and the current version specification is technically correct, the comment doesn't meet our threshold for being necessary.
    Delete this comment as it suggests an unnecessary style change that doesn't improve code quality or fix any actual issues.
2. terraform/go.mod:3
  • Draft comment:
go 1.23
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment identifies a real issue - 1.23.2 is not a valid Go version. However, the suggested fix (1.23) is also invalid. A better suggestion would be to use a real Go version like 1.22. Since both the original and suggested versions are invalid, this comment isn't helpful.
    The comment does point out a real problem with an invalid Go version. Maybe we should keep it to alert the author that there's an issue?
    While it identifies a problem, the suggested fix is also incorrect. We should reject comments that provide incorrect solutions.
    Delete the comment because it suggests replacing one invalid Go version with another invalid Go version.

Workflow ID: wflow_1i2T85Vmy75rGWDu


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terraform provider

1 participant