Conversation
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 52b52c9 in 1 minute and 11 seconds
More details
- Looked at
990lines of code in10files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pkg/acl/nodeattributes/nodeattributes.go:132
- Draft comment:
Redundant comment. The comment on line 132 is repeated and can be removed for clarity. - Reason this comment was not posted:
Confidence changes required:10%
The code inpkg/acl/nodeattributes/nodeattributes.gohas a redundant comment on line 132. The comment is repeated twice, which is unnecessary and can be removed for clarity.
Workflow ID: wflow_ir3FLXl3ABKGLmr5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add Terraform provider support for managing TACL node attributes with examples.
nodeattrresource and data source innodeattr_resource.goandnodeattr_data_source.go.provider.goto includeNewNodeAttrResourceandNewNodeAttrDataSource.nodeattributes.go.NodeAttrGrantInputandExtendedNodeAttrGrantstructs.example.tfdemonstrating usage oftacl_nodeattrresource.This description was created by
for 52b52c9. It will automatically update as commits are pushed.