Skip to content

feat(terraform): add nodeattr resource and data source for TACL#15

Merged
jaxxstorm merged 1 commit intomainfrom
nodeattrs
Jan 21, 2025
Merged

feat(terraform): add nodeattr resource and data source for TACL#15
jaxxstorm merged 1 commit intomainfrom
nodeattrs

Conversation

@jaxxstorm
Copy link
Copy Markdown
Member

@jaxxstorm jaxxstorm commented Jan 21, 2025

Important

Add Terraform provider support for managing TACL node attributes with examples.

  • Terraform Provider:
    • Adds nodeattr resource and data source in nodeattr_resource.go and nodeattr_data_source.go.
    • Updates provider.go to include NewNodeAttrResource and NewNodeAttrDataSource.
  • Node Attributes:
    • Implements CRUD operations for node attributes in nodeattributes.go.
    • Introduces NodeAttrGrantInput and ExtendedNodeAttrGrant structs.
  • Examples:
    • Adds example.tf demonstrating usage of tacl_nodeattr resource.

This description was created by Ellipsis for 52b52c9. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev bot changed the title ... feat(terraform): add nodeattr resource and data source for TACL Jan 21, 2025
Copy link
Copy Markdown

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 52b52c9 in 1 minute and 11 seconds

More details
  • Looked at 990 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pkg/acl/nodeattributes/nodeattributes.go:132
  • Draft comment:
    Redundant comment. The comment on line 132 is repeated and can be removed for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The code in pkg/acl/nodeattributes/nodeattributes.go has a redundant comment on line 132. The comment is repeated twice, which is unnecessary and can be removed for clarity.

Workflow ID: wflow_ir3FLXl3ABKGLmr5


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@jaxxstorm jaxxstorm merged commit ca34dfc into main Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant