Skip to content

feat: add version flag, Dockerfile, and GoReleaser configuration#18

Merged
jaxxstorm merged 4 commits intomainfrom
release_config
Jan 22, 2025
Merged

feat: add version flag, Dockerfile, and GoReleaser configuration#18
jaxxstorm merged 4 commits intomainfrom
release_config

Conversation

@jaxxstorm
Copy link
Copy Markdown
Member

@jaxxstorm jaxxstorm commented Jan 22, 2025

  • feat: Add version flag to print application version
  • docs: Add .goreleaser.yml configuration file
  • refactor: add goreleaser and fun gofmt
  • feat: add Dockerfile

Important

Add version flag, Dockerfile, GoReleaser configuration, and refactor CLI parsing with Kong.

  • Features:
    • Add version flag in main.go and terraform/main.go to print application version.
    • Add Dockerfile for building Docker images.
  • Refactor:
    • Use Kong for CLI argument parsing in main.go.
    • Update terraform/provider/nodeattr_resource.go for better error handling and logging.
  • Configuration:
    • Add .goreleaser.yml for GoReleaser configuration.
    • Add .dockerignore to exclude unnecessary files from Docker builds.
  • Dependencies:
    • Remove github.com/google/uuid from go.mod.

This description was created by Ellipsis for a8e0daf. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev bot changed the title ... feat: add version flag, Dockerfile, and GoReleaser configuration Jan 22, 2025
@jaxxstorm jaxxstorm merged commit 73bc85b into main Jan 22, 2025
Copy link
Copy Markdown

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a8e0daf in 1 minute and 52 seconds

More details
  • Looked at 8278 lines of code in 28 files
  • Skipped 1 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. Dockerfile:15
  • Draft comment:
    Consider setting a WORKDIR in the final image to ensure the application runs from the expected directory. This can prevent potential issues if the application relies on being executed from a specific path.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The Dockerfile is missing a step to set the working directory in the final image. This can lead to issues if the application expects to be run from a specific directory.
2. go.mod:3
  • Draft comment:
    The Go version specified (1.23.2) is not valid. Consider using a valid Go version, such as 1.21.
  • Reason this comment was not posted:
    Comment was on unchanged code.
3. main.go:66
  • Draft comment:
    Consider using the zap logger for printing the version to maintain consistency with the rest of the application's logging strategy.
  • Reason this comment was not posted:
    Confidence changes required: 30%
    The main.go file uses fmt.Println for printing the version, which is fine for CLI tools. However, using a logger would be more consistent with the rest of the application, which uses zap for logging.
4. terraform/main.go:23
  • Draft comment:
    Consider using a logger instead of log.Printf for printing the version to maintain consistency with the rest of the application's logging strategy.
  • Reason this comment was not posted:
    Confidence changes required: 30%
    The terraform/main.go file uses log.Printf for printing the version, which is fine for CLI tools. However, using a logger would be more consistent with the rest of the application, which uses zap for logging.

Workflow ID: wflow_F4iLX1MRN2JxgGEE


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant