Rename ltypes.py to lpython.py #1620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
approved these changes
Mar 24, 2023
Contributor
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
I think that this is fine, I didn't see any issues, but I would like @czgdp1807, @Smit-create and @Thirumalai-Shaktivel to also review, to ensure we didn't miss anything.
Smit-create
approved these changes
Mar 24, 2023
Collaborator
Smit-create
left a comment
Smit-create
left a comment
There was a problem hiding this comment.
I think it looks good, just a rename so shouldn't have any issues.
czgdp1807
approved these changes
Mar 25, 2023
Thirumalai-Shaktivel
approved these changes
Mar 25, 2023
Contributor
|
Ok, let's merge it then. If anything breaks, let's fix it as we go. Thanks @ADV1K for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1602
I have changed all the imports and related instances of ltypes to lpython.
However I do have some doubts regarding the changes inside
python_ast_to_asr.cppas changing the variable names from ltypes to lpython might be confusing. Please do let me know if i should revert that change.I have also tested that importing lpython works and updated the test references.