fix: avoid panic in TagDeclarationExtension.tag on partial elaboration
#11882
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a guard to `TagDeclarationExtension.tag` to check if the declaration name is anonymous and return early if so. This prevents a panic that could occur when modifiers like `meta` or `noncomputable` are used in combination with syntax errors. Reproducer: ```lean public meta section def private ``` Previously this would panic with: ``` PANIC at Lean.EnvExtension.modifyState: called on `async` extension, must set `asyncDecl` in that case ``` This follows the same pattern as the fix in #10131 for `addDocString` and the existing guard in `markNotMeta`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Kha
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a guard to
TagDeclarationExtension.tagto check if the declaration name is anonymous and return early if so. This prevents a panic that could occur when modifiers likemetaornoncomputableare used in combination with syntax errors.Reproducer:
Previously this would panic with:
This follows the same pattern as the fix in #10131 for
addDocStringand the existing guard inmarkNotMeta.See https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/panic.20on.20doc-string/near/566110399
🤖 Prepared with Claude Code