Conversation
Percy Visual Test ResultsPercy Dashboard: View Detailed Report Environment:
Instructions for Reviewers:
|
AlexVelezLl
left a comment
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thanks @MisRob! Updates make sense to me, just a couple of comments/questions, but nothing blocking! :)
| <ul> | ||
| <li>Set <code>isDecorative</code> on <code>KImg</code> for correct accessibility</li> | ||
| <li> | ||
| Utilize <code>KImg</code>'s <code>placeholder</code> slot for placeholder content (<code>thumbnailPlaceholder</code> |
There was a problem hiding this comment.
I got a (little) bit confused because of the thumbnail placeholder slot, thumbnail slot, and this KImg's placeholder slot. But I think I finally got it, the thumbnail-placeholder is only applicable for thubmnailSrc, right?
I think it is this paragraph that isn't entirely clear to me, that this is talking specifically about the thumbnailSrc and not about the thumbnail slot.
When KCard is set to display the thumbnail, the thumbnail area acts as a placeholder if the image is missing, fails to load, or is still loading. In such cases, a light gray background is shown in place of the image.
Also, something that isn't clear to me by just reading this, if we set KCard to display the thumbnail using the thumbnail slot, we also get this gray background when the image is missing, fails to load or still loading? (im not completely profficient with KImg yet) 😅
| <li>Background color: $k-grey-900</li> | ||
| <li>Text: 14px white and bolded</li> | ||
| <li>Height: 48px</li> | ||
| <li>Timeout: 5 seconds</li> |
There was a problem hiding this comment.
In the current KSnackbar PR, we are using 4000 ms as the default. Should we already update this in the scope of that PR, right? (i.e., are planning to do this in a follow-up?)
| <strong>Use assertive messages only for critical information that requires immediate | ||
| attention.</strong> |
There was a problem hiding this comment.
For me, as a developer, it is still a bit abstract what a "critical information that requires immediate attention" is; it'd be great if we had some examples here.
2 participants
Description
KCardthumbnailslotuseKLiveRegionguidanceIssue addressed
Changelog
KCard, anduseKLiveRegiondocumentation pagesKCard,useKLiveRegionSteps to test
Preview updated areas on the following pages: