Development and contributing guidelines updates#11560
Merged
marcellamaki merged 3 commits intolearningequality:release-v0.16.xfrom Nov 30, 2023
Merged
Development and contributing guidelines updates#11560marcellamaki merged 3 commits intolearningequality:release-v0.16.xfrom
marcellamaki merged 3 commits intolearningequality:release-v0.16.xfrom
Conversation
- Suggest contributors ask for a reasonable amount of issues - Add a note on our response times - Add "How to connect section" - Remove "Kolibri" when possible so that guidelines can be copied/pasted more easily accross other repositories - Mark important point in bold - Minor wording tweaks
- Remove duplicate or unnecessary information - Cleanup titles
MisRob
added
TODO: needs review
8 tasks
Contributor
Build Artifacts
|
marcellamaki
approved these changes
Nov 30, 2023
Member
marcellamaki
left a comment
marcellamaki
left a comment
There was a problem hiding this comment.
this looks great, thank you @MisRob!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewer guidance
Testing checklist
If there are any front-end changes, before/after screenshots are includedCritical user journeys are covered by Gherkin storiesCritical and brittle code paths are covered by unit testsPR process
If this is an important user-facing change, PR or related issue has a 'changelog' labelIf this includes an internal dependency change, a link to the diff is providedReviewer checklist
yarnandpip)