Skip to content

Use update_dirty_bit_to in pre_save to allow null user fields during deserialization#14234

Merged
bjester merged 5 commits intolearningequality:release-v0.19.xfrom
ozer550:align-course-model-pre-save-logic
Mar 20, 2026
Merged

Use update_dirty_bit_to in pre_save to allow null user fields during deserialization#14234
bjester merged 5 commits intolearningequality:release-v0.19.xfrom
ozer550:align-course-model-pre-save-logic

Conversation

@ozer550
Copy link
Member

@ozer550 ozer550 commented Feb 24, 2026

Summary

  • Pass save kwargs to pre_save and use update_dirty_bit_to for user field null enforcement.
  • Update tests to incorporate new changes.

References

Reviewer guidance

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small labels Feb 24, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

@bjester bjester self-assigned this Feb 24, 2026
@bjester bjester self-requested a review February 24, 2026 15:06
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, changes look good! I think it would still be good to wait until after this one is merged (then rebase), since then we can run the morango integ tests and have extra assurance on the syncing aspects.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be retargeted to release-v0.19.x - but I'm also going to block it for a little longer to allow the integration tests to be merged, and also to wait until 0.19.2 has been released!

@bjester
Copy link
Member

bjester commented Feb 26, 2026

@rtibbles ah great catch! 🤦

@ozer550 ozer550 force-pushed the align-course-model-pre-save-logic branch from b79df85 to e18dbcf Compare March 2, 2026 09:35
@ozer550 ozer550 changed the base branch from develop to release-v0.19.x March 2, 2026 09:35
@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment DEV: renderers HTML5 apps, videos, exercises, etc. APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) SIZE: very large APP: User Re: User app (sign-in, sign-up, user profile, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend DEV: tools Internal tooling for development labels Mar 2, 2026
@rtibbles rtibbles removed DEV: dev-ops Continuous integration & deployment DEV: renderers HTML5 apps, videos, exercises, etc. APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend labels Mar 2, 2026
@rtibbles rtibbles removed DEV: tools Internal tooling for development SIZE: small SIZE: very large labels Mar 2, 2026
@ozer550 ozer550 force-pushed the align-course-model-pre-save-logic branch from e18dbcf to 6fc3f2b Compare March 12, 2026 18:20
@github-actions github-actions bot added the APP: Learn Re: Learn App (content, quizzes, lessons, etc.) label Mar 12, 2026
@ozer550 ozer550 requested review from bjester and rtibbles March 12, 2026 18:21
@bjester bjester merged commit c8a0923 into learningequality:release-v0.19.x Mar 20, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: backend Python, databases, networking, filesystem... SIZE: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align course model pre_save logic with awareness of deserialization

3 participants