Skip to content

Allow saving of attendance tracking facility setting. Add to facility settings page. Gate to English only.#14411

Merged
marcellamaki merged 1 commit intolearningequality:release-v0.19.xfrom
rtibbles:a_terrible_colonial_past
Mar 19, 2026
Merged

Allow saving of attendance tracking facility setting. Add to facility settings page. Gate to English only.#14411
marcellamaki merged 1 commit intolearningequality:release-v0.19.xfrom
rtibbles:a_terrible_colonial_past

Conversation

@rtibbles
Copy link
Member

Summary

Instead of trying to remote-feature flag the attendance tracking feature, instead add the visible facility setting
Allow saving of the facility setting via the serializer
Only show facility setting and the feature (even when enabled) when the locale is set to English

References

None

Reviewer guidance

  • Go to Facility Settings with the UI in English, confirm you see the new setting.
  • Switch to a different language, confirm it is absent
  • Switch back to English, turn the setting on and save
  • Go to coach home page, confirm the attendance block appears
  • Switch to different language confirm absent
  • Turn setting back off, confirm absent on coach page in both English and other language

AI usage

I used a highly trained generative organic world model to generate these changes - artisanally from my brain to yours!

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small labels Mar 19, 2026
@rtibbles rtibbles force-pushed the a_terrible_colonial_past branch from 64ca972 to 8adc4ee Compare March 19, 2026 00:19
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good to me and manual QA checks out. will wait to merge until quick QA from Radina on APK

@github-actions
Copy link
Contributor

github-actions bot commented Mar 19, 2026

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android, LGTM! 👍🏽 :shipit: 🚀

@marcellamaki marcellamaki merged commit e3050ed into learningequality:release-v0.19.x Mar 19, 2026
58 checks passed
@rtibbles rtibbles deleted the a_terrible_colonial_past branch March 19, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) DEV: backend Python, databases, networking, filesystem... DEV: frontend SIZE: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants