Allow saving of attendance tracking facility setting. Add to facility settings page. Gate to English only.#14411
Merged
marcellamaki merged 1 commit intolearningequality:release-v0.19.xfrom Mar 19, 2026
Conversation
… settings page. Gate to English only.
64ca972 to
8adc4ee
Compare
Member
marcellamaki
left a comment
There was a problem hiding this comment.
code changes look good to me and manual QA checks out. will wait to merge until quick QA from Radina on APK
Contributor
Build Artifacts
Smoke test screenshot |
radinamatic
approved these changes
Mar 19, 2026
Member
radinamatic
left a comment
There was a problem hiding this comment.
Tested on Android, LGTM! 👍🏽
🚀
e3050ed
into
learningequality:release-v0.19.x
58 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instead of trying to remote-feature flag the attendance tracking feature, instead add the visible facility setting
Allow saving of the facility setting via the serializer
Only show facility setting and the feature (even when enabled) when the locale is set to English
References
None
Reviewer guidance
AI usage
I used a highly trained generative organic world model to generate these changes - artisanally from my brain to yours!