Add constants for bloomd format#139
Merged
rtibbles merged 2 commits intolearningequality:mainfrom Aug 30, 2024
Merged
Conversation
jredrejo
previously requested changes
Aug 2, 2024
Member
jredrejo
left a comment
jredrejo
left a comment
There was a problem hiding this comment.
Tests are not passing because you added both bloomd and bloompub as choices in constants/format_presets.py while only bloompub in resources/presetlookup.json
If there are not differences in the way the reader interfaces with the two formats I think it would be better to use a different approach, like the one used with video_subtitle .
rtibbles
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bloomd format to integrated the bloom files coming from OPDS client
#124
#36