Adds content_id property to embed_content_request schema#156
Merged
bjester merged 2 commits intolearningequality:mainfrom Mar 17, 2025
Merged
Adds content_id property to embed_content_request schema#156bjester merged 2 commits intolearningequality:mainfrom
bjester merged 2 commits intolearningequality:mainfrom
Conversation
bjester
requested changes
Mar 5, 2025
Member
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
I think we should be consistent with validation across the schema. Either direction is fine with me as long as it's consistent
Member
|
@akolson Lets figure out what to do here together because I have another addition assigned to me. The decision may have repercussions on code in Studio and CA API, so we should determine that and write up issues if necessary. |
bjester
approved these changes
Mar 17, 2025
Member
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
As a consequence, we'll have to ensure Studio formats the UUIDs with dashes when it makes the request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr adds the
content_idproperty to the embed_content_request json schema.References
Fixes #154
Reviewer guidance